From: Vladimir Prus <ghost@cs.msu.su>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Stop infrun from tracking breakpoint insertion status.
Date: Mon, 19 Nov 2007 17:00:00 -0000 [thread overview]
Message-ID: <fhsf5r$1aq$1@ger.gmane.org> (raw)
In-Reply-To: <200711191139.lAJBdRFc027229@d12av02.megacenter.de.ibm.com>
Ulrich Weigand wrote:
> Vladimir Prus wrote:
>
>> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
>> index e81ec20..ef55a3d 100644
>> --- a/gdb/breakpoint.c
>> +++ b/gdb/breakpoint.c
>> @@ -296,6 +296,8 @@ int breakpoint_count;
>> /* Pointer to current exception event record */
>> static struct exception_event_record *current_exception_event;
>>
>> +static int breakpoints_meant_to_be_inserted_p;
>> +
>> /* This function returns a pointer to the string representation of the
>> pathname of the dynamically-linked library that has just been
>> loaded.
>> @@ -1312,6 +1314,12 @@ remove_breakpoints (void)
>> }
>>
>> int
>> +breakpoints_meant_to_be_inserted (void)
>> +{
>> + return breakpoints_meant_to_be_inserted_p;
>> +}
>> +
>> +int
>> remove_hw_watchpoints (void)
>> {
>> struct bp_location *b;
>
>
> Is the breakpoints_meant_to_be_inserted_p variable actually ever
> set to any non-zero value in this patch?
Oops! It's not, which suggest that the three uses of that function are:
(i) not excercised by gdb testsuite and (ii) they are probably less
important than I originally though.
I'll put the right assignemnts to breakpoints_meant_to_be_inserted_p
and look at the code in question again.
Sorry,
Volodya
next prev parent reply other threads:[~2007-11-19 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 11:41 Vladimir Prus
2007-11-19 11:39 ` Ulrich Weigand
2007-11-19 17:00 ` Vladimir Prus [this message]
2007-11-20 20:48 ` Vladimir Prus
2007-11-22 0:49 ` Ulrich Weigand
2007-11-22 15:21 ` Vladimir Prus
2007-11-26 15:25 ` Ulrich Weigand
2007-11-27 17:49 ` Vladimir Prus
2007-11-27 18:14 ` Ulrich Weigand
2007-11-28 12:50 ` Vladimir Prus
2007-11-27 18:55 ` Vladimir Prus
2007-11-28 22:24 ` Ulrich Weigand
2007-11-29 18:46 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fhsf5r$1aq$1@ger.gmane.org' \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox