From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28858 invoked by alias); 19 Nov 2007 17:00:34 -0000 Received: (qmail 28850 invoked by uid 22791); 19 Nov 2007 17:00:33 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Nov 2007 16:56:46 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Iu9ut-00041V-4F for gdb-patches@sources.redhat.com; Mon, 19 Nov 2007 16:56:11 +0000 Received: from 77.246.241.246 ([77.246.241.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 19 Nov 2007 16:56:11 +0000 Received: from ghost by 77.246.241.246 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 19 Nov 2007 16:56:11 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [RFA] Stop infrun from tracking breakpoint insertion status. Date: Mon, 19 Nov 2007 17:00:00 -0000 Message-ID: References: <200711181440.50407.vladimir@codesourcery.com> <200711191139.lAJBdRFc027229@d12av02.megacenter.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00368.txt.bz2 Ulrich Weigand wrote: > Vladimir Prus wrote: > >> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c >> index e81ec20..ef55a3d 100644 >> --- a/gdb/breakpoint.c >> +++ b/gdb/breakpoint.c >> @@ -296,6 +296,8 @@ int breakpoint_count; >> /* Pointer to current exception event record */ >> static struct exception_event_record *current_exception_event; >> >> +static int breakpoints_meant_to_be_inserted_p; >> + >> /* This function returns a pointer to the string representation of the >> pathname of the dynamically-linked library that has just been >> loaded. >> @@ -1312,6 +1314,12 @@ remove_breakpoints (void) >> } >> >> int >> +breakpoints_meant_to_be_inserted (void) >> +{ >> + return breakpoints_meant_to_be_inserted_p; >> +} >> + >> +int >> remove_hw_watchpoints (void) >> { >> struct bp_location *b; > > > Is the breakpoints_meant_to_be_inserted_p variable actually ever > set to any non-zero value in this patch? Oops! It's not, which suggest that the three uses of that function are: (i) not excercised by gdb testsuite and (ii) they are probably less important than I originally though. I'll put the right assignemnts to breakpoints_meant_to_be_inserted_p and look at the code in question again. Sorry, Volodya