Re: Remove CLEAR_SOLIB

[Vladimir Prus <ghost@cs.msu.su>]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Daniel Jacobowitz wrote:

> On Wed, Nov 14, 2007 at 02:57:52PM +0300, Vladimir Prus wrote:
>> 
>> It turns out that CLEAR_SOLIB macro is being tested
>> for in a couple of places, but it never set anywhere.
>> This patch removes all traces of it. OK?
> 
> OK.  But really, we ask everyone else to write ChangeLog entries when
> they post patches... I'd appreciate if you could too.

Thanks, here's the final version I've checked in.

- Volodya


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: clear_solib_final.diff --]
[-- Type: text/x-diff; name="clear_solib_final.diff", Size: 2902 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/ChangeLog,v
retrieving revision 1.769
diff -u -p -r1.769 ChangeLog
--- ChangeLog	23 Oct 2007 12:34:11 -0000	1.769
+++ ChangeLog	15 Nov 2007 06:10:18 -0000
@@ -1,3 +1,9 @@
+2007-10-15  Vladimir Prus  <vladimir@codesourcery.com>
+
+	Remove CLEAR_SOLIB use.
+	* corelow.c (core_close): Don't check for CLEAR_SOLIB.
+	* infcmd.c (attach_command): Likewise.
+	
 2007-10-23  Daniel Jacobowitz  <dan@codesourcery.com>
 
 	* Makefile.def (dependencies): Make configure-gdb depend on
Index: gdb/corelow.c
===================================================================
RCS file: /cvs/src/src/gdb/corelow.c,v
retrieving revision 1.69
diff -u -p -r1.69 corelow.c
--- gdb/corelow.c	30 Oct 2007 21:46:25 -0000	1.69
+++ gdb/corelow.c	15 Nov 2007 06:10:18 -0000
@@ -199,11 +199,7 @@ core_close (int quitting)
 
       /* Clear out solib state while the bfd is still open. See
          comments in clear_solib in solib.c. */
-#ifdef CLEAR_SOLIB
-      CLEAR_SOLIB ();
-#else
       clear_solib ();
-#endif
 
       name = bfd_get_filename (core_bfd);
       if (!bfd_close (core_bfd))
Index: gdb/infcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.162
diff -u -p -r1.162 infcmd.c
--- gdb/infcmd.c	25 Oct 2007 11:30:55 -0000	1.162
+++ gdb/infcmd.c	15 Nov 2007 06:10:19 -0000
@@ -1887,11 +1887,7 @@ attach_command (char *args, int from_tty
      (gdb) attach 4712
      Cannot access memory at address 0xdeadbeef
   */
-#ifdef CLEAR_SOLIB
-      CLEAR_SOLIB ();
-#else
-      clear_solib ();
-#endif
+  clear_solib ();
 
   target_attach (args, from_tty);
 
Index: gdb/doc/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/doc/ChangeLog,v
retrieving revision 1.717
diff -u -p -r1.717 ChangeLog
--- gdb/doc/ChangeLog	12 Nov 2007 05:20:36 -0000	1.717
+++ gdb/doc/ChangeLog	15 Nov 2007 06:10:21 -0000
@@ -1,3 +1,8 @@
+2007-11-15  Vladimir Prus  <vladimir@codesourcery.com>
+
+	* gdbint.texinfo (Native Conditionals): Remove
+	mention of CLEAR_SOLIB.
+	
 2007-11-11  Joel Brobecker  <brobecker@adacore.com>
 
 	* gdb.texinfo (Print Settings): Add documentation for "set/show
Index: gdb/doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.274
diff -u -p -r1.274 gdbint.texinfo
--- gdb/doc/gdbint.texinfo	24 Oct 2007 20:29:14 -0000	1.274
+++ gdb/doc/gdbint.texinfo	15 Nov 2007 06:10:24 -0000
@@ -4675,10 +4675,6 @@ the shell execs, and once when the progr
 number of traps is something other than 2, then define this macro to
 expand into the number expected.
 
-@item CLEAR_SOLIB
-@findex CLEAR_SOLIB
-See @file{objfiles.c}.
-
 @end table
 
 @node Support Libraries