From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17424 invoked by alias); 15 Nov 2007 06:21:52 -0000 Received: (qmail 17414 invoked by uid 22791); 15 Nov 2007 06:21:51 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 Nov 2007 06:21:49 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IsY4s-0006Ye-QB for gdb-patches@sources.redhat.com; Thu, 15 Nov 2007 06:19:50 +0000 Received: from 77.246.241.246 ([77.246.241.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 15 Nov 2007 06:19:50 +0000 Received: from ghost by 77.246.241.246 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 15 Nov 2007 06:19:50 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: Remove CLEAR_SOLIB Date: Thu, 15 Nov 2007 06:21:00 -0000 Message-ID: References: <200711141457.52644.vladimir@codesourcery.com> <20071114132001.GA7291@caradoc.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart1340466.ufjnr0vUWf" Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00297.txt.bz2 --nextPart1340466.ufjnr0vUWf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8Bit Content-length: 445 Daniel Jacobowitz wrote: > On Wed, Nov 14, 2007 at 02:57:52PM +0300, Vladimir Prus wrote: >> >> It turns out that CLEAR_SOLIB macro is being tested >> for in a couple of places, but it never set anywhere. >> This patch removes all traces of it. OK? > > OK. But really, we ask everyone else to write ChangeLog entries when > they post patches... I'd appreciate if you could too. Thanks, here's the final version I've checked in. - Volodya --nextPart1340466.ufjnr0vUWf Content-Type: text/x-diff; name="clear_solib_final.diff" Content-Transfer-Encoding: 8Bit Content-Disposition: attachment; filename="clear_solib_final.diff" Content-length: 2902 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/ChangeLog,v retrieving revision 1.769 diff -u -p -r1.769 ChangeLog --- ChangeLog 23 Oct 2007 12:34:11 -0000 1.769 +++ ChangeLog 15 Nov 2007 06:10:18 -0000 @@ -1,3 +1,9 @@ +2007-10-15 Vladimir Prus + + Remove CLEAR_SOLIB use. + * corelow.c (core_close): Don't check for CLEAR_SOLIB. + * infcmd.c (attach_command): Likewise. + 2007-10-23 Daniel Jacobowitz * Makefile.def (dependencies): Make configure-gdb depend on Index: gdb/corelow.c =================================================================== RCS file: /cvs/src/src/gdb/corelow.c,v retrieving revision 1.69 diff -u -p -r1.69 corelow.c --- gdb/corelow.c 30 Oct 2007 21:46:25 -0000 1.69 +++ gdb/corelow.c 15 Nov 2007 06:10:18 -0000 @@ -199,11 +199,7 @@ core_close (int quitting) /* Clear out solib state while the bfd is still open. See comments in clear_solib in solib.c. */ -#ifdef CLEAR_SOLIB - CLEAR_SOLIB (); -#else clear_solib (); -#endif name = bfd_get_filename (core_bfd); if (!bfd_close (core_bfd)) Index: gdb/infcmd.c =================================================================== RCS file: /cvs/src/src/gdb/infcmd.c,v retrieving revision 1.162 diff -u -p -r1.162 infcmd.c --- gdb/infcmd.c 25 Oct 2007 11:30:55 -0000 1.162 +++ gdb/infcmd.c 15 Nov 2007 06:10:19 -0000 @@ -1887,11 +1887,7 @@ attach_command (char *args, int from_tty (gdb) attach 4712 Cannot access memory at address 0xdeadbeef */ -#ifdef CLEAR_SOLIB - CLEAR_SOLIB (); -#else - clear_solib (); -#endif + clear_solib (); target_attach (args, from_tty); Index: gdb/doc/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/doc/ChangeLog,v retrieving revision 1.717 diff -u -p -r1.717 ChangeLog --- gdb/doc/ChangeLog 12 Nov 2007 05:20:36 -0000 1.717 +++ gdb/doc/ChangeLog 15 Nov 2007 06:10:21 -0000 @@ -1,3 +1,8 @@ +2007-11-15 Vladimir Prus + + * gdbint.texinfo (Native Conditionals): Remove + mention of CLEAR_SOLIB. + 2007-11-11 Joel Brobecker * gdb.texinfo (Print Settings): Add documentation for "set/show Index: gdb/doc/gdbint.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.274 diff -u -p -r1.274 gdbint.texinfo --- gdb/doc/gdbint.texinfo 24 Oct 2007 20:29:14 -0000 1.274 +++ gdb/doc/gdbint.texinfo 15 Nov 2007 06:10:24 -0000 @@ -4675,10 +4675,6 @@ the shell execs, and once when the progr number of traps is something other than 2, then define this macro to expand into the number expected. -@item CLEAR_SOLIB -@findex CLEAR_SOLIB -See @file{objfiles.c}. - @end table @node Support Libraries --nextPart1340466.ufjnr0vUWf--