From: Hafiz Abid Qadeer <abid_qadeer@mentor.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>,
<jiangshuai_li@c-sky.com>, <yunhai_shang@c-sky.com>
Subject: Re: [1/2] C-SKY Port
Date: Tue, 28 Aug 2018 11:47:00 -0000 [thread overview]
Message-ID: <fba6a2d3-7e21-7399-fdb6-df3dc8a70bab@mentor.com> (raw)
In-Reply-To: <20180826092857.GA6698@adacore.com>
Hi Joel,
Thanks for the review.
On 26/08/18 10:28, Joel Brobecker wrote:
>> 2018-07-27 Jiangshuai Li <jiangshuai_li@c-sky.com>
>> Hafiz Abid Qadeer <abidh@codesourcery.com>
>> Don Breazeal <donb@codesourcery.com>
>>
>> * csky-linux-tdep.c: New file.
>> * csky-tdep.c: Likewise.
>> * csky-tdep.h: Likewise.
>> * Makefile.in (ALL_TARGET_OBS): Add csky-linux-tdep.o and
>> csky-tdep.o.
>> (HFILES_NO_SRCDIR): Add csky-tdep.h.
>> (ALLDEPFILES): Add csky-linux-tdep.c and csky-tdep.c
>> * configure.tgt: Add csky support.
>
> This new version looks fine to me. Please feel free to push to master.
I have pushed it to master. The patch needed a few small changes after I
rebased it to latest.
https://sourceware.org/ml/gdb-cvs/2018-08/msg00122.html
>
> As for gdb-8.2-branch, this would be fine by me, on the basis that
> this cannot affect the other already-supported targets.
>
I decided to not put it in 8.2 as binutils ports went in after the 8.2
branch was cut.
I will update the MAINTAINERS file with the port maintainer info shortly.
Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
next prev parent reply other threads:[~2018-08-28 11:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 10:43 [0/2] " Hafiz Abid Qadeer
2018-07-25 10:54 ` [1/2] " Hafiz Abid Qadeer
2018-07-27 15:49 ` Tom Tromey
2018-07-27 23:13 ` Hafiz Abid Qadeer
2018-08-08 10:53 ` Hafiz Abid Qadeer
2018-08-17 9:18 ` Abid, Hafiz
2018-08-24 9:15 ` Hafiz Abid Qadeer
2018-08-26 9:29 ` Joel Brobecker
2018-08-28 11:47 ` Hafiz Abid Qadeer [this message]
2018-10-21 2:55 ` Simon Marchi
2018-10-21 3:04 ` Hafiz Abid Qadeer
2018-10-21 3:22 ` Simon Marchi
2018-10-23 12:49 ` Hafiz Abid Qadeer
2018-10-23 16:42 ` Simon Marchi
2018-10-23 22:31 ` Hafiz Abid Qadeer
2018-07-25 10:55 ` [2/2] " Hafiz Abid Qadeer
2018-07-25 14:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba6a2d3-7e21-7399-fdb6-df3dc8a70bab@mentor.com \
--to=abid_qadeer@mentor.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jiangshuai_li@c-sky.com \
--cc=tom@tromey.com \
--cc=yunhai_shang@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox