From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91449 invoked by alias); 28 Aug 2018 11:47:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91436 invoked by uid 89); 28 Aug 2018 11:47:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*f:sk:12ad95f, H*f:sk:87tvok6, sk:already, H*f:sk:dd7b53d X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 11:47:13 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1fucSk-0004OP-Sr from abid_qadeer@mentor.com ; Tue, 28 Aug 2018 04:47:10 -0700 Received: from [137.202.204.206] (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 28 Aug 2018 12:47:06 +0100 Subject: Re: [1/2] C-SKY Port To: Joel Brobecker CC: Tom Tromey , , , References: <87tvok65mf.fsf@tromey.com> <12ad95ff-3ce8-89ed-5a54-e10cf6e06ee7@mentor.com> <20180826092857.GA6698@adacore.com> From: Hafiz Abid Qadeer Message-ID: Date: Tue, 28 Aug 2018 11:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180826092857.GA6698@adacore.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00681.txt.bz2 Hi Joel, Thanks for the review. On 26/08/18 10:28, Joel Brobecker wrote: >> 2018-07-27 Jiangshuai Li >> Hafiz Abid Qadeer >> Don Breazeal >> >> * csky-linux-tdep.c: New file. >> * csky-tdep.c: Likewise. >> * csky-tdep.h: Likewise. >> * Makefile.in (ALL_TARGET_OBS): Add csky-linux-tdep.o and >> csky-tdep.o. >> (HFILES_NO_SRCDIR): Add csky-tdep.h. >> (ALLDEPFILES): Add csky-linux-tdep.c and csky-tdep.c >> * configure.tgt: Add csky support. > > This new version looks fine to me. Please feel free to push to master. I have pushed it to master. The patch needed a few small changes after I rebased it to latest. https://sourceware.org/ml/gdb-cvs/2018-08/msg00122.html > > As for gdb-8.2-branch, this would be fine by me, on the basis that > this cannot affect the other already-supported targets. > I decided to not put it in 8.2 as binutils ports went in after the 8.2 branch was cut. I will update the MAINTAINERS file with the port maintainer info shortly. Thanks, -- Hafiz Abid Qadeer Mentor Embedded/CodeSourcery