From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Unconditionally pass is_a_field_of_this in c-exp.y
Date: Sun, 7 Dec 2025 09:22:13 -0500 [thread overview]
Message-ID: <fb4df02e-d4c1-46b5-a3e4-ec1edef2cdec@simark.ca> (raw)
In-Reply-To: <20251206180541.189881-1-tom@tromey.com>
On 2025-12-06 13:05, Tom Tromey wrote:
> In a review to a different patch of mine, Simon asked for this change.
> The idea here is that there's no need to pass null as the "field of
> this" parameter, as lookup_language_this checks the language anyway.
I didn't recall the logic exactly so I checked again. For languages for
which "this" is not relevant, lang->name_of_this() will return nullptr
in lookup_language_this. Is that it?
If so:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2025-12-07 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 18:05 Tom Tromey
2025-12-07 14:22 ` Simon Marchi [this message]
2025-12-07 15:21 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb4df02e-d4c1-46b5-a3e4-ec1edef2cdec@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox