From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PS0cJ7GNNWmu3CEAWB0awg (envelope-from ) for ; Sun, 07 Dec 2025 09:22:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765117361; bh=1qWIGRrMsssw61tiP1FJ2FjnC5VM9Wpekjvd9Tpmut8=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RwPUmnh5eFzhRpYFy4Lg5n8rt3K+esctmMeF2Mu+6gosQLSw7MYLiXA9ONm+liCUh WPISuYywgmfNOpjmIsr0nMd2/q7hhADHgSDobHSPsostbw6ACulFI2H/KQLnBNL0Lc Htfh9He1lca6aatEyjrgSz6ySp840F81IUoOPF44= Received: by simark.ca (Postfix, from userid 112) id 934BE1E08D; Sun, 07 Dec 2025 09:22:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: *** X-Spam-Status: No, score=3.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=n/xSBoib; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E3CC31E08D for ; Sun, 07 Dec 2025 09:22:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70CA951A3BA2 for ; Sun, 7 Dec 2025 14:22:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70CA951A3BA2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=n/xSBoib Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7708248FB401 for ; Sun, 7 Dec 2025 14:22:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7708248FB401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7708248FB401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765117334; cv=none; b=D4Konh4CyLt53SO4+hiCiyFykzdzYKW2BOJpL5UL92IbOr2jcg9xFWha2SzII0XQ0cg6Nx3Z3qmiGZc54lxePE/mS7pS/zkxcqqorXzdzYT9zc5CZfJW0BD5/35s5FsbnwGK4EKaqqhQchW23CuSihkcpFmlijrrAkOorh9hlmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765117334; c=relaxed/simple; bh=1qWIGRrMsssw61tiP1FJ2FjnC5VM9Wpekjvd9Tpmut8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=np6NQCdxMRWE6Qd+jEnhnQlig2bxr/7lJ0kXP/H4kIig+Qm0AncDfuURbrGCkWsI3JbmuIxMReGTeri4+0g6yrefHwZo2MPC06D3KDb6IFYEBXqW0iW4hnKZKMnkJE8hEH2CJ/on32sEnltp0qtZwu8e7Jh36PJbNvu9yfsPPnc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7708248FB401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765117333; bh=1qWIGRrMsssw61tiP1FJ2FjnC5VM9Wpekjvd9Tpmut8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=n/xSBoibakryav3Qquy6B4/V7mpJEHBTRTJPaID6Z8VqOE3QP0hrnzHF0YQqlZ3kB X3a965owb7vL3J0CemtJwc/QhtnQ4sD5n5G+2v3CydPN8P+EqEZS8G7eodS3z6430K 68juGInrUIYu1BFj5FXZ/NS062wkQQ71vX/VUIJ4= Received: by simark.ca (Postfix) id C6A6D1E08D; Sun, 07 Dec 2025 09:22:13 -0500 (EST) Message-ID: Date: Sun, 7 Dec 2025 09:22:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Unconditionally pass is_a_field_of_this in c-exp.y To: Tom Tromey , gdb-patches@sourceware.org References: <20251206180541.189881-1-tom@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20251206180541.189881-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-12-06 13:05, Tom Tromey wrote: > In a review to a different patch of mine, Simon asked for this change. > The idea here is that there's no need to pass null as the "field of > this" parameter, as lookup_language_this checks the language anyway. I didn't recall the logic exactly so I checked again. For languages for which "this" is not relevant, lang->name_of_this() will return nullptr in lookup_language_this. Is that it? If so: Approved-By: Simon Marchi Simon