From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Jordan Rupprecht <rupprecht@google.com>,
gdb-patches@sourceware.org,
Eric Christopher <echristo@gmail.com>,
David Blaikie <dblaikie@gmail.com>,
dje@google.com
Subject: Re: [PATCH] [dwarf2read] Fix crash when loading dwp files: calculate num_sections based on actual section indices, not just the number of sections.
Date: Tue, 26 Feb 2019 16:24:00 -0000 [thread overview]
Message-ID: <fb2a135bd1e57e0bd5c66f51ce8a4341@polymtl.ca> (raw)
In-Reply-To: <87wolmlh8g.fsf@tromey.com>
On 2019-02-26 10:08, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
>>> - dwp_file->num_sections = bfd_count_sections (dwp_file->dbfd) + 1;
>>> + dwp_file->num_sections = elf_numsections (dwp_file->dbfd);
>
> Simon> I have tweaked the original commit message a bit and pushed.
> Simon> Thanks again for the patch.
>
> I wonder if there's any way to reach this with a non-ELF objfile --
> Mach-O seems probable. I think we also handle DWARF on AIX (ECOFF
> IIRC)
> but I don't know if that does dwp.
Oh, maybe. Unfortunately, I don't have access to a Mac to test this at
the moment.
I'll give it a try on gcc119.fsffrance.org for AIX.
Simon
next prev parent reply other threads:[~2019-02-26 16:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 0:54 Jordan Rupprecht via gdb-patches
2019-02-24 4:01 ` Simon Marchi
2019-02-25 20:17 ` Jordan Rupprecht via gdb-patches
2019-02-25 20:21 ` Jordan Rupprecht via gdb-patches
2019-02-25 20:55 ` Simon Marchi
2019-02-25 21:22 ` Jordan Rupprecht via gdb-patches
2019-02-26 15:08 ` Tom Tromey
2019-02-26 16:24 ` Simon Marchi [this message]
2019-02-27 4:41 ` Simon Marchi
2019-02-27 17:22 ` Tom Tromey
2019-02-27 17:40 ` Simon Marchi
2019-02-27 17:56 ` Eric Christopher
2019-02-27 18:06 ` Adrian Prantl
2019-02-27 18:13 ` Simon Marchi
2019-02-27 19:33 ` David Blaikie
2019-02-25 20:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb2a135bd1e57e0bd5c66f51ce8a4341@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=dblaikie@gmail.com \
--cc=dje@google.com \
--cc=echristo@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=rupprecht@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox