From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95244 invoked by alias); 26 Feb 2019 16:24:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61648 invoked by uid 89); 26 Feb 2019 16:24:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:830 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Feb 2019 16:24:22 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x1QGO1Tu031898 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 26 Feb 2019 11:24:06 -0500 Received: by simark.ca (Postfix, from userid 112) id D5EB31E660; Tue, 26 Feb 2019 11:24:01 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id AC9511E4A5; Tue, 26 Feb 2019 11:24:00 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 26 Feb 2019 16:24:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Jordan Rupprecht , gdb-patches@sourceware.org, Eric Christopher , David Blaikie , dje@google.com Subject: Re: [PATCH] [dwarf2read] Fix crash when loading dwp files: calculate num_sections based on actual section indices, not just the number of sections. In-Reply-To: <87wolmlh8g.fsf@tromey.com> References: <439bf4f6859a539472a2e51a028b9503@polymtl.ca> <20190225201715.144927-1-rupprecht@google.com> <1b6df15638153631ea87fa1bc7c24dd2@polymtl.ca> <87wolmlh8g.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00438.txt.bz2 On 2019-02-26 10:08, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> - dwp_file->num_sections = bfd_count_sections (dwp_file->dbfd) + 1; >>> + dwp_file->num_sections = elf_numsections (dwp_file->dbfd); > > Simon> I have tweaked the original commit message a bit and pushed. > Simon> Thanks again for the patch. > > I wonder if there's any way to reach this with a non-ELF objfile -- > Mach-O seems probable. I think we also handle DWARF on AIX (ECOFF > IIRC) > but I don't know if that does dwp. Oh, maybe. Unfortunately, I don't have access to a Mac to test this at the moment. I'll give it a try on gcc119.fsffrance.org for AIX. Simon