From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH v2 4/4] gdb/dwarf: fix reading DW_FORM_addrx with address size of 2
Date: Thu, 24 Sep 2026 11:59:33 -0400 [thread overview]
Message-ID: <fb18b527-b3d8-49d1-85cd-3a13676d7954@polymtl.ca> (raw)
In-Reply-To: <8733v0j8zw.fsf@tromey.com>
On 9/23/26 11:13 AM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> @@ -14658,25 +14660,34 @@ read_addr_index_1 (dwarf2_per_objfile *per_objfile, unsigned int addr_index,
>
> Simon> + ULONGEST entry_offset = static_cast<ULONGEST> (addr_index) * addr_size;
>
> Since the only use is in a cast to another type, perhaps the type should
> just be ULONGEST in the signature.
I did this change. All the callers start with a 64 address index vlaue
anyway, so we might as well just pass it as 64 bits all the way through.
Pushed with that changed, thanks.
Simon
next prev parent reply other threads:[~2026-09-24 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 17:39 [PATCH v2 0/4] Fix " Simon Marchi
2026-09-21 17:39 ` [PATCH v2 1/4] gdb/testsuite: add support for DWARF 5 .debug_addr sections to DWARF assembler Simon Marchi
2026-09-21 17:39 ` [PATCH v2 2/4] gdb/dwarf: validate address sizes when reading DWARF headers Simon Marchi
2026-09-21 17:39 ` [PATCH v2 3/4] gdb/dwarf: don't store segment_collector_size (sic) Simon Marchi
2026-09-21 17:39 ` [PATCH v2 4/4] gdb/dwarf: fix reading DW_FORM_addrx with address size of 2 Simon Marchi
2026-09-23 15:13 ` Tom Tromey
2026-09-24 15:59 ` Simon Marchi [this message]
2026-09-23 15:49 ` [PATCH v2 0/4] Fix " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb18b527-b3d8-49d1-85cd-3a13676d7954@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox