From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MSoaHQlJtWo5bj0AWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 12:00:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=UADS75vl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6F6801E01F; Thu, 24 Sep 2026 12:00:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C02EA1E01F for ; Thu, 24 Sep 2026 12:00:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62FFC48FDED0 for ; Thu, 24 Sep 2026 16:00:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62FFC48FDED0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=UADS75vl Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 833DD4B35880; Thu, 24 Sep 2026 15:59:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 833DD4B35880 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 833DD4B35880 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790265583; cv=none; b=wDK+ZEXwj776dmtTv2oWQCMkiqL1FsOnZu56oQQUKraMaKFkwKnpyWKlBLtLAohXZB1zzs+mtSEHEntPUpvdKPKSAIeuXwgcNOt4ThsF1fdZZPAdbSAbqak8ovBtKLtg4npTbaalFrj67Jt9kKjIv2laDGG90OSvvxbKpyvjBTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790265583; c=relaxed/simple; bh=zi+YMLemlVs0W7y0BBMTt6bT/n42EbFMNkOkKyUttQ4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jECVExwCewqo8kyI+D+/AFgwcNiGFLUrU5KVXigDTnPYUgvhgUvMJWTkAUz48NmNpRivE205vLTRQ9ux2wgu69SLrLaibV5vVkUGofX2/TL4iE9/kh1q5gbrgKidzMP84Ng8pYRHEO6chPDEDB5yJ9RxSc1p1BKSa81EvQwUOLE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=UADS75vl DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 833DD4B35880 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 68OFxakT092319 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Sep 2026 11:59:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 68OFxakT092319 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1790265582; bh=/3Cw27L/HopNGs55oAgipikf4kDeReoKq421mCqBjx4=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=UADS75vleR21NB1kWDPG52axPXSDsQLg21XPagNVJnWqWqgXYzYK0/uHBQkQZEf08 O6E7GxXNyTT4ksHt6P92oB1r4j3BnxvyObowZfpziAejkjTSbHzxgOIMIykhc/axzK RiXp9FM5Mgv/f1FNPJQpXGmtxSM0y9aqRgTkbRl2WUVSHqQE3OP100P+5fkTnTH3g2 O7z3+Do32xvRWSmDrYPQqm7VRJa8SYFfielcwgUTPWbz97ByubUdskdOXD4s5RV6L3 ry9Eclz4WiaNDakZovx4TUflqwuGTLS8wWlZcdmoe/1vQYteJTwCITyX395X2MSeZG s/AchY1hjzqqA== Received: by simark.ca (Postfix) id EBF281E01F; Thu, 24 Sep 2026 11:59:33 -0400 (EDT) Message-ID: Date: Thu, 24 Sep 2026 11:59:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] gdb/dwarf: fix reading DW_FORM_addrx with address size of 2 To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org, binutils@sourceware.org References: <20260921173951.688121-1-simon.marchi@efficios.com> <20260921173951.688121-5-simon.marchi@efficios.com> <8733v0j8zw.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <8733v0j8zw.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 Sep 2026 15:59:36 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/23/26 11:13 AM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> @@ -14658,25 +14660,34 @@ read_addr_index_1 (dwarf2_per_objfile *per_objfile, unsigned int addr_index, > > Simon> + ULONGEST entry_offset = static_cast (addr_index) * addr_size; > > Since the only use is in a cast to another type, perhaps the type should > just be ULONGEST in the signature. I did this change. All the callers start with a 64 address index vlaue anyway, so we might as well just pass it as 64 bits all the way through. Pushed with that changed, thanks. Simon