From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 00/12] More type macros removal
Date: Sun, 12 Jul 2020 23:15:47 -0400 [thread overview]
Message-ID: <fac6d980-c691-5eab-a7bf-fbdd6040d9d4@polymtl.ca> (raw)
In-Reply-To: <20200706133833.145408-1-simon.marchi@polymtl.ca>
On 2020-07-06 9:38 a.m., Simon Marchi wrote:
> Here is the next installment of removal of type macros, in favor of
> getter/setter methods.
>
> I added some assertions in some of these methods, to verify that the
> method is called on a type with the expected code (this is one of the
> goal of these changes). It found one case that needed to be fixed,
> handled by patch 3.
>
> The rest should be relatively straightforward.
>
> Simon Marchi (12):
> gdb: add type::bounds / type::set_bounds
> gdb: remove TYPE_RANGE_DATA macro
> gdb: make get_discrete_bounds check for non-constant range bounds
> gdb: add accessors to struct dynamic_prop
> gdb: remove TYPE_HIGH_BOUND and TYPE_LOW_BOUND
> gdb: remove TYPE_LOW_BOUND_UNDEFINED and TYPE_HIGH_BOUND_UNDEFINED
> gdb: remove TYPE_LOW_BOUND_KIND and TYPE_HIGH_BOUND_KIND
> gdb: remove TYPE_ARRAY_{UPPER,LOWER}_BOUND_IS_UNDEFINED
> gdb: remove TYPE_ARRAY_{LOWER,UPPER}_BOUND_VALUE
> gdb: remove TYPE_BIT_STRIDE
> gdb: remove TYPE_ARRAY_BIT_STRIDE
> gdb: make type::bounds work for array and string types
>
> gdb/ada-lang.c | 22 ++--
> gdb/ada-tasks.c | 7 +-
> gdb/ada-typeprint.c | 8 +-
> gdb/ada-valprint.c | 2 +-
> gdb/c-typeprint.c | 4 +-
> gdb/c-varobj.c | 18 ++-
> gdb/compile/compile-c-symbols.c | 6 +-
> gdb/compile/compile-c-types.c | 10 +-
> gdb/compile/compile-cplus-types.c | 10 +-
> gdb/ctfread.c | 2 +-
> gdb/dwarf2/loc.c | 16 +--
> gdb/dwarf2/read.c | 71 +++++-------
> gdb/eval.c | 8 +-
> gdb/f-typeprint.c | 4 +-
> gdb/f-valprint.c | 10 +-
> gdb/gdbtypes.c | 186 +++++++++++++-----------------
> gdb/gdbtypes.h | 162 +++++++++++++++++++-------
> gdb/gnu-v3-abi.c | 3 +-
> gdb/guile/scm-type.c | 7 +-
> gdb/m2-typeprint.c | 20 ++--
> gdb/m2-valprint.c | 4 +-
> gdb/mdebugread.c | 8 +-
> gdb/p-typeprint.c | 10 +-
> gdb/p-valprint.c | 2 +-
> gdb/printcmd.c | 3 +-
> gdb/python/py-type.c | 7 +-
> gdb/rust-lang.c | 8 +-
> gdb/type-stack.c | 3 +-
> gdb/valarith.c | 11 +-
> gdb/valops.c | 2 +-
> gdb/value.c | 4 +-
> 31 files changed, 337 insertions(+), 301 deletions(-)
>
> --
> 2.27.0
>
I pushed this.
Simon
prev parent reply other threads:[~2020-07-13 3:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 13:38 Simon Marchi
2020-07-06 13:38 ` [PATCH 01/12] gdb: add type::bounds / type::set_bounds Simon Marchi
2020-07-06 13:38 ` [PATCH 02/12] gdb: remove TYPE_RANGE_DATA macro Simon Marchi
2020-07-06 13:38 ` [PATCH 03/12] gdb: make get_discrete_bounds check for non-constant range bounds Simon Marchi
2020-07-06 13:38 ` [PATCH 04/12] gdb: add accessors to struct dynamic_prop Simon Marchi
2020-07-06 13:38 ` [PATCH 05/12] gdb: remove TYPE_HIGH_BOUND and TYPE_LOW_BOUND Simon Marchi
2020-07-06 13:38 ` [PATCH 06/12] gdb: remove TYPE_LOW_BOUND_UNDEFINED and TYPE_HIGH_BOUND_UNDEFINED Simon Marchi
2020-07-06 13:38 ` [PATCH 07/12] gdb: remove TYPE_LOW_BOUND_KIND and TYPE_HIGH_BOUND_KIND Simon Marchi
2020-07-06 13:38 ` [PATCH 08/12] gdb: remove TYPE_ARRAY_{UPPER, LOWER}_BOUND_IS_UNDEFINED Simon Marchi
2020-07-06 13:38 ` [PATCH 09/12] gdb: remove TYPE_ARRAY_{LOWER,UPPER}_BOUND_VALUE Simon Marchi
2020-07-06 13:50 ` [PATCH 00/12] More type macros removal Simon Marchi
2020-07-11 22:27 ` Tom Tromey
2020-07-11 23:05 ` Simon Marchi
2020-07-13 3:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac6d980-c691-5eab-a7bf-fbdd6040d9d4@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox