From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 883263857C5A for ; Mon, 13 Jul 2020 03:15:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 883263857C5A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 06D3Fofk031793 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 12 Jul 2020 23:15:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 06D3Fofk031793 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B3BF91E111 for ; Sun, 12 Jul 2020 23:15:49 -0400 (EDT) Subject: Re: [PATCH 00/12] More type macros removal To: gdb-patches@sourceware.org References: <20200706133833.145408-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: Date: Sun, 12 Jul 2020 23:15:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200706133833.145408-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 13 Jul 2020 03:15:50 +0000 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2020 03:15:56 -0000 On 2020-07-06 9:38 a.m., Simon Marchi wrote: > Here is the next installment of removal of type macros, in favor of > getter/setter methods. > > I added some assertions in some of these methods, to verify that the > method is called on a type with the expected code (this is one of the > goal of these changes). It found one case that needed to be fixed, > handled by patch 3. > > The rest should be relatively straightforward. > > Simon Marchi (12): > gdb: add type::bounds / type::set_bounds > gdb: remove TYPE_RANGE_DATA macro > gdb: make get_discrete_bounds check for non-constant range bounds > gdb: add accessors to struct dynamic_prop > gdb: remove TYPE_HIGH_BOUND and TYPE_LOW_BOUND > gdb: remove TYPE_LOW_BOUND_UNDEFINED and TYPE_HIGH_BOUND_UNDEFINED > gdb: remove TYPE_LOW_BOUND_KIND and TYPE_HIGH_BOUND_KIND > gdb: remove TYPE_ARRAY_{UPPER,LOWER}_BOUND_IS_UNDEFINED > gdb: remove TYPE_ARRAY_{LOWER,UPPER}_BOUND_VALUE > gdb: remove TYPE_BIT_STRIDE > gdb: remove TYPE_ARRAY_BIT_STRIDE > gdb: make type::bounds work for array and string types > > gdb/ada-lang.c | 22 ++-- > gdb/ada-tasks.c | 7 +- > gdb/ada-typeprint.c | 8 +- > gdb/ada-valprint.c | 2 +- > gdb/c-typeprint.c | 4 +- > gdb/c-varobj.c | 18 ++- > gdb/compile/compile-c-symbols.c | 6 +- > gdb/compile/compile-c-types.c | 10 +- > gdb/compile/compile-cplus-types.c | 10 +- > gdb/ctfread.c | 2 +- > gdb/dwarf2/loc.c | 16 +-- > gdb/dwarf2/read.c | 71 +++++------- > gdb/eval.c | 8 +- > gdb/f-typeprint.c | 4 +- > gdb/f-valprint.c | 10 +- > gdb/gdbtypes.c | 186 +++++++++++++----------------- > gdb/gdbtypes.h | 162 +++++++++++++++++++------- > gdb/gnu-v3-abi.c | 3 +- > gdb/guile/scm-type.c | 7 +- > gdb/m2-typeprint.c | 20 ++-- > gdb/m2-valprint.c | 4 +- > gdb/mdebugread.c | 8 +- > gdb/p-typeprint.c | 10 +- > gdb/p-valprint.c | 2 +- > gdb/printcmd.c | 3 +- > gdb/python/py-type.c | 7 +- > gdb/rust-lang.c | 8 +- > gdb/type-stack.c | 3 +- > gdb/valarith.c | 11 +- > gdb/valops.c | 2 +- > gdb/value.c | 4 +- > 31 files changed, 337 insertions(+), 301 deletions(-) > > -- > 2.27.0 > I pushed this. Simon