Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Doug Evans <dje@google.com>,
	gdb-patches <gdb-patches@sourceware.org>,
	       Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH, doc RFA] Fix lazy string type docs
Date: Fri, 04 Nov 2016 19:20:00 -0000	[thread overview]
Message-ID: <fa977c23-f6e3-f735-a102-65970c3f5f86@redhat.com> (raw)
In-Reply-To: <CADPb22RqLmN4+pS1hx1Q5rtnyYen4KJVfCzMWrcg7R=pJNPb9A@mail.gmail.com>

On 04/11/16 17:52, Doug Evans wrote:
> On Thu, Nov 3, 2016 at 5:00 PM, Doug Evans <dje@google.com> wrote:
>> On Thu, Nov 3, 2016 at 12:03 PM, Doug Evans <dje@google.com> wrote:
>>> On Thu, Nov 3, 2016 at 10:46 AM, Doug Evans <dje@google.com> wrote:
>>>> Hi.
>>>>

>>>
>>> (gdb) py print gdb.parse_and_eval("foo").lazy_string().type
>>> const char
>>> (gdb) py print gdb.parse_and_eval("bar").lazy_string().type
>>> const char [19]
>>>
>>> I don't have a strong opinion on what the correct answer is, but there
>>> is certainly a bug here.
>>>
>>> Phil, do you remember why this code exists in valpy_lazy_string():
>>>
>>>       if (TYPE_CODE (value_type (value)) == TYPE_CODE_PTR)
>>>         value = value_ind (value);
>>>
>>> [lazy string support went in in commit be759fcf]

I can't remember. Too many sleeps ;) It's possible it is just a
mistake and we're worrying about a bug that should just be fixed.

I think lazy strings were implemented to carry around a string that
remains unfetched (in cases of massive strings) until actually needed,
or a pointer to that string. I also thought there was some work
carried out on them by Tom (?) after the initial commit.

I keep notes and I'll look on the weekend to see of I can dig out
specific implementation details.

Cheers

Phil


  reply	other threads:[~2016-11-04 19:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 17:46 Doug Evans
2016-11-03 18:21 ` Eli Zaretskii
2016-11-03 18:36   ` Doug Evans
     [not found]   ` <CADPb22QnnuHuG+sC=rg5HUJP2L_m1P_J7TTFLv0H-KDd6tON=A@mail.gmail.com>
2016-11-03 19:07     ` Eli Zaretskii
2016-11-03 23:55       ` Doug Evans
2016-11-04  7:31         ` Eli Zaretskii
2016-11-03 19:04 ` Doug Evans
2016-11-03 21:20   ` André Pönitz
2016-11-04  0:01   ` Doug Evans
2016-11-04 17:53     ` Doug Evans
2016-11-04 19:20       ` Phil Muldoon [this message]
2016-11-04 19:29         ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa977c23-f6e3-f735-a102-65970c3f5f86@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox