Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "André Pönitz" <apoenitz@t-online.de>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
	Eli Zaretskii <eliz@gnu.org>,	Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [PATCH, doc RFA] Fix lazy string type docs
Date: Thu, 03 Nov 2016 21:20:00 -0000	[thread overview]
Message-ID: <20161103222909.GA3858@klara.mpi.htwm.de> (raw)
In-Reply-To: <CADPb22QvOHADZuv1x4UJ4x28k0_jFEqoatgcaJYdX5RwJUaiTQ@mail.gmail.com>

On Thu, Nov 03, 2016 at 12:03:46PM -0700, Doug Evans wrote:
> To fix this bug we're going to have to break one or the other, or add
> a knob (bleah) to control the old, broken, behaviour.

Adding a knob to enable the old behaviour does not really help
frontends, as with the same effort a frontend adds a "set knob
enabled" command it could just adapt to the new behaviour.

> Or mark the "type" LazyString attribute as broken/deprecated and
> provide a new attribute with correct behaviour.  [...]
> Opinions?

To be honest, I don't really have an opinion on which is better or even
correct, as it is still rather unclear to me in which situation a
frontend would benefit from using gdb.LazyString at all. To me, the need
to specify an encoding or rely on GDB to select something appropriate
seems to be a disadvantage over keeping a (address, length) pair and
using gdb.Inferior.read_memory() when needed, especially when the
contents of that memory can be corrupted and not necessarily contain
data of an intended encoding anymore.

André

PS: 

> [...] will select the most appropriate
> encoding when the sting is printed [...]
 
s/sting/string/ ? (also copied to guile/scm-lazy-string.c)


  reply	other threads:[~2016-11-03 21:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 17:46 Doug Evans
2016-11-03 18:21 ` Eli Zaretskii
2016-11-03 18:36   ` Doug Evans
     [not found]   ` <CADPb22QnnuHuG+sC=rg5HUJP2L_m1P_J7TTFLv0H-KDd6tON=A@mail.gmail.com>
2016-11-03 19:07     ` Eli Zaretskii
2016-11-03 23:55       ` Doug Evans
2016-11-04  7:31         ` Eli Zaretskii
2016-11-03 19:04 ` Doug Evans
2016-11-03 21:20   ` André Pönitz [this message]
2016-11-04  0:01   ` Doug Evans
2016-11-04 17:53     ` Doug Evans
2016-11-04 19:20       ` Phil Muldoon
2016-11-04 19:29         ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161103222909.GA3858@klara.mpi.htwm.de \
    --to=apoenitz@t-online.de \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox