From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Rohr, Stephan" <stephan.rohr@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbserver/win32-low.cc: remove use of `all_threads`
Date: Tue, 3 Dec 2024 10:54:46 -0500 [thread overview]
Message-ID: <fa0fcc66-092a-49ea-b1f2-b8c8ad06daf2@polymtl.ca> (raw)
In-Reply-To: <DS7PR11MB6247BB8C03C8315F4F12E7B193362@DS7PR11MB6247.namprd11.prod.outlook.com>
On 12/3/24 4:03 AM, Rohr, Stephan wrote:
> This seems reasonable. We could also use
>
> process_info *process = find_process_pid (pid);
>
> if (process == NULL)
> return;
>
> if (process->thread_map ().size () == 1)
> return;
Yeah, something like this seems even more future proof. I'll send a v2
that looks like that, thanks.
Simon
next prev parent reply other threads:[~2024-12-03 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 19:47 Simon Marchi
2024-12-02 20:48 ` Rohr, Stephan
2024-12-03 2:48 ` Simon Marchi
2024-12-03 9:03 ` Rohr, Stephan
2024-12-03 15:54 ` Simon Marchi [this message]
2024-12-03 14:34 ` Hannes Domani
2024-12-03 15:58 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa0fcc66-092a-49ea-b1f2-b8c8ad06daf2@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=stephan.rohr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox