Re: [PATCH] gdbserver/win32-low.cc: remove use of `all_threads`

[Hannes Domani <ssbssa@yahoo.de>]

 Am Montag, 2. Dezember 2024 um 20:50:34 MEZ hat Simon Marchi <simon.marchi@polymtl.ca> Folgendes geschrieben:

> Fix this:
>
>     /home/simark/src/binutils-gdb/gdbserver/win32-low.cc: In function ‘void child_delete_thread(DWORD, DWORD)’:
>     /home/simark/src/binutils-gdb/gdbserver/win32-low.cc:192:7: error: ‘all_threads’ was not declared in this scope; did you mean ‘using_threads’?
>       192 |  if (all_threads.size () == 1)
>           |      ^~~~~~~~~~~
>           |      using_threads
>
> Commit 9f77b3aa0bfc ("gdbserver: change 'all_processes' and
> 'all_threads' list type") changed the type of `all_thread` to an
> intrusive_list, without changing this particular use, which broke the
> build because an intrusive_list doesn't know its size (we, could,
> Boost's version has an option for that, but we don't need it at the
> moment).  The subsequent commit removed `all_threads`, leading to the
> error above.
>
> Fix it by using the number of threads of the current process instead.
> My rationale: as far as I know, GDBserver on Windows only supports one
> process at a time, so there's no need to iterate over all processes.  It
> would be nice if someone familiar with the Windows port could confirm
> (and test) this.

I tested it now, and there seems to be no problem.

But this if() actually never triggered for me, I never got an
EXIT_THREAD_DEBUG_EVENT for the final thread, only an
EXIT_PROCESS_DEBUG_EVENT.
I tried it out on both Win7 and Win11, but maybe there is some special
constellation where this can happen, or it was different on earlier
Windows versions.

Tested-By: Hannes Domani <ssbssa@yahoo.de>


Hannes


> Change-Id: I84d6226532b887d99248cf3be90f5065fb7a074a
> ---
> gdbserver/win32-low.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc
> index 0174a32e5d19..ef00f3452f31 100644
> --- a/gdbserver/win32-low.cc
> +++ b/gdbserver/win32-low.cc
> @@ -189,7 +189,7 @@ static void
> child_delete_thread (DWORD pid, DWORD tid)
> {
>   /* If the last thread is exiting, just return.  */
> -  if (all_threads.size () == 1)
> +  if (current_process ()->thread_map ().size () == 1)
>     return;
>
>   thread_info *thread = find_thread_ptid (ptid_t (pid, tid));
>
> base-commit: 3eccfdce99e030be759ea20c66d6f78978b11a25
> --
> 2.47.1