Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Allow resetting an empty inferior-tty
Date: Wed, 24 Aug 2016 15:24:00 -0000	[thread overview]
Message-ID: <f9ab962e-bde6-fe7b-355e-11908f5c4c7b@ericsson.com> (raw)
In-Reply-To: <83y43mdx6m.fsf@gnu.org>

On 16-08-24 11:05 AM, Eli Zaretskii wrote:
> Thanks.  If the argument is optional, please show it as such, as we do
> elsewhere in the manual.

Does that mean with square brackets?

  @item set inferior-tty [ @var{tty} ]

I see some commands with optional arguments that use them, but many others
(break, frame, list, etc.) do not, so I wasn't sure.

> OK with this nit fixed.
> 
> P.S.  Btw, it is strange that your log entry says
> 
>   gdb/doc/ChangeLog:
> 
> 	  * gdb.texinfo (Your Program’s Input and Output): Mention
> 	  possibility to unset inferior-tty.
> 
> whereas the node's name is "Input/Output", and the section's name is
> "Your Program's Input and Output", without any non-ASCII characters.
> What happened there?

I copied the title from the generated html version, and it seems like the
single quote is being changed to an actual apostrophe.  I'll change it to
a single quote, as it is in the source file.  Or is it better if I use the
node name instead (Input/Output)?

Thanks for the quick review.

Simon




  reply	other threads:[~2016-08-24 15:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 14:52 Simon Marchi
2016-08-24 15:05 ` Eli Zaretskii
2016-08-24 15:24   ` Simon Marchi [this message]
2016-08-24 15:58     ` Eli Zaretskii
2016-08-24 15:33 ` Pedro Alves
2016-08-24 15:38   ` Simon Marchi
2016-08-24 15:41     ` Pedro Alves
2016-08-24 15:55       ` Simon Marchi
2016-08-24 16:20         ` Pedro Alves
2016-08-24 17:11           ` Simon Marchi
2016-08-24 17:22             ` Simon Marchi
2016-08-29 10:55               ` [testsuite patch+7.12] gdb.base/default.exp regression [Re: [PATCH] Allow resetting an empty inferior-tty] Jan Kratochvil
2016-08-29 12:39                 ` Simon Marchi
2016-08-29 13:01                 ` Pedro Alves
2016-08-29 13:22                   ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9ab962e-bde6-fe7b-355e-11908f5c4c7b@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox