From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109554 invoked by alias); 24 Aug 2016 15:24:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108616 invoked by uid 89); 24 Aug 2016 15:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Zaretskii, zaretskii X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Aug 2016 15:24:44 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by (Symantec Mail Security) with SMTP id A4.89.02568.76DBDB75; Wed, 24 Aug 2016 17:29:43 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.301.0; Wed, 24 Aug 2016 11:20:52 -0400 Subject: Re: [PATCH] Allow resetting an empty inferior-tty To: Eli Zaretskii References: <20160824144548.19204-1-simon.marchi@ericsson.com> <83y43mdx6m.fsf@gnu.org> CC: From: Simon Marchi Message-ID: Date: Wed, 24 Aug 2016 15:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <83y43mdx6m.fsf@gnu.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00245.txt.bz2 On 16-08-24 11:05 AM, Eli Zaretskii wrote: > Thanks. If the argument is optional, please show it as such, as we do > elsewhere in the manual. Does that mean with square brackets? @item set inferior-tty [ @var{tty} ] I see some commands with optional arguments that use them, but many others (break, frame, list, etc.) do not, so I wasn't sure. > OK with this nit fixed. >=20 > P.S. Btw, it is strange that your log entry says >=20 > gdb/doc/ChangeLog: >=20 > * gdb.texinfo (Your Program=E2=80=99s Input and Output): Mention > possibility to unset inferior-tty. >=20 > whereas the node's name is "Input/Output", and the section's name is > "Your Program's Input and Output", without any non-ASCII characters. > What happened there? I copied the title from the generated html version, and it seems like the single quote is being changed to an actual apostrophe. I'll change it to a single quote, as it is in the source file. Or is it better if I use the node name instead (Input/Output)? Thanks for the quick review. Simon