From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix phony iconv build
Date: Mon, 17 Oct 2016 16:04:00 -0000 [thread overview]
Message-ID: <f864cd89-3068-7877-9da9-d479ff410c4f@redhat.com> (raw)
In-Reply-To: <871szf3r0j.fsf@tromey.com>
On 10/17/2016 04:59 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> This is a regression caused by commit cda6c55bd399 (Turn wchar
> Pedro> iterator into a class). The problem is that iconv_t is now exposed in
> Pedro> charset.h, while before it was only used in charset.c. gdb/charset.c,
> Pedro> under #ifdef PHONY_ICONV, does:
>
> I'm sorry about that.
No worries. Seems like no build slave is exercising this
code path.
> Pedro> So it seems the simplest is to use 'int' in the header file too.
> Pedro> Tromey, WDYT?
>
> Looks good, thanks.
Thanks, I'll push it in soon.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-10-17 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 14:16 Pedro Alves
2016-10-17 16:00 ` Tom Tromey
2016-10-17 16:04 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f864cd89-3068-7877-9da9-d479ff410c4f@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox