From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28988 invoked by alias); 17 Oct 2016 16:04:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28962 invoked by uid 89); 17 Oct 2016 16:04:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=slave X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 16:04:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B76DF1555E; Mon, 17 Oct 2016 16:04:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9HG434c000625; Mon, 17 Oct 2016 12:04:03 -0400 Subject: Re: [PATCH] Fix phony iconv build To: Tom Tromey References: <1476713788-18547-1-git-send-email-palves@redhat.com> <871szf3r0j.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 17 Oct 2016 16:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <871szf3r0j.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00487.txt.bz2 On 10/17/2016 04:59 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This is a regression caused by commit cda6c55bd399 (Turn wchar > Pedro> iterator into a class). The problem is that iconv_t is now exposed in > Pedro> charset.h, while before it was only used in charset.c. gdb/charset.c, > Pedro> under #ifdef PHONY_ICONV, does: > > I'm sorry about that. No worries. Seems like no build slave is exercising this code path. > Pedro> So it seems the simplest is to use 'int' in the header file too. > Pedro> Tromey, WDYT? > > Looks good, thanks. Thanks, I'll push it in soon. Thanks, Pedro Alves