From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix inheritance of finish_breakpoint_object
Date: Mon, 14 Sep 2026 09:38:58 -0400 [thread overview]
Message-ID: <f77b01b4-b59e-4c6d-8497-760efe26ee66@simark.ca> (raw)
In-Reply-To: <20260912142115.3717539-1-tom@tromey.com>
On 9/12/26 10:21 AM, Tom Tromey wrote:
> I noticed that finish_breakpoint_object does not derive from PyObject,
> but instead uses the older C-style inheritance. This patch fixes
> this.
- Missing
static_assert (gdb::is_python_allocatable_v<finish_breakpoint_object>);
as mandated by the comment in python-traits.h
- The two local variables in bpfinishpy_out_of_scope can be removed, in
favor of just using bpfinish_obj directly.
Otherwise, LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-09-14 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 14:21 Tom Tromey
2026-09-14 13:38 ` Simon Marchi [this message]
2026-09-14 14:12 ` Simon Marchi
2026-09-14 15:32 ` Tom Tromey
2026-09-14 15:33 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f77b01b4-b59e-4c6d-8497-760efe26ee66@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox