From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0k3YDg/5p2qfHwwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 09:39:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789393167; bh=T5feOnc2UKmGM0pDFESZA99I2N59RdOlm3JlGGO6KeU=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a6z4+eCgMcp0CfEeYBg3TrDTl5purKPczxurWLyG/z2BCIKEqCFnWdbF7tVIgDKc5 0ruAU415GGwoHj8bbkGdkcs7dMmrTAYP8nacgkCV/NCEHBgycQEs5eL3j9z4/lbVnu Y4R6cBbn90aG8RmAJ3hZyrgpHUN/LD2AKbWwH438= Received: by simark.ca (Postfix, from userid 112) id 0B4571E066; Mon, 14 Sep 2026 09:39:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=K8k20jIs; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D2891E01F for ; Mon, 14 Sep 2026 09:39:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FB814BB1C0D for ; Mon, 14 Sep 2026 13:39:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FB814BB1C0D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=K8k20jIs Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8229B4BAE7F2 for ; Mon, 14 Sep 2026 13:39:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8229B4BAE7F2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8229B4BAE7F2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789393141; cv=none; b=qcHjN7wBHWzCgI9exvbe27a9bZ4278A239UZcADuEDWVREKfVnW5qqnOwad/KOcGHv3bcFbr8b9gosYqVduQh187es2kdGyUVdEUmw24O/tpR87CBtGw6W+1A+47nI1NVKYUVeXmuqDXt279a1oYs7ZB57jdURCQE4CXQmwm4Ac= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789393141; c=relaxed/simple; bh=T5feOnc2UKmGM0pDFESZA99I2N59RdOlm3JlGGO6KeU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=yGeDHriSYQJHfjDgcrw0WJcwc8ewhJ7hE1OvnTa8LX/lHOuiPhgh599CYjpI0DxAxshIh4uj+wHXvBzL3Nd8ithpaPPp5obC5lgBu1xR8zN4EpvGyqMZaEBxvsFWZE3hByIMbhRnBG7PDN66qjoy0CBO+TqoU4Nab9NQZtFezPI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=K8k20jIs DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8229B4BAE7F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789393139; bh=T5feOnc2UKmGM0pDFESZA99I2N59RdOlm3JlGGO6KeU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=K8k20jIsitA4U0VsPWsWk0969+IfQ0ZgrBQN2TG2UIVnS28mHr6o1oaq9MQvVkY1S fSSlS0bj8XRd/9GI+0J5x9T9nYSEIxs78Cni0jDEdbwOTK/VNXNxzOwv3KsYDyciVS h9gsz9girUUQu1CTyvBz1WbbBiyBusa48cjgm2G0= Received: by simark.ca (Postfix) id 3DF3F1E01F; Mon, 14 Sep 2026 09:38:59 -0400 (EDT) Message-ID: Date: Mon, 14 Sep 2026 09:38:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix inheritance of finish_breakpoint_object To: Tom Tromey , gdb-patches@sourceware.org References: <20260912142115.3717539-1-tom@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260912142115.3717539-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/12/26 10:21 AM, Tom Tromey wrote: > I noticed that finish_breakpoint_object does not derive from PyObject, > but instead uses the older C-style inheritance. This patch fixes > this. - Missing static_assert (gdb::is_python_allocatable_v); as mandated by the comment in python-traits.h - The two local variables in bpfinishpy_out_of_scope can be removed, in favor of just using bpfinish_obj directly. Otherwise, LGTM. Approved-By: Simon Marchi Simon