Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.base/inline-frame-cycle-unwind.exp for s390x (alternative)
Date: Wed, 21 Jan 2026 14:09:44 +0100	[thread overview]
Message-ID: <f6ea6267-0548-462f-9e1f-cc1ea0454833@suse.de> (raw)
In-Reply-To: <877btchvf2.fsf@redhat.com>

On 1/20/26 9:38 PM, Andrew Burgess wrote:
> Having spent some time now running and debugging this test, I think one
> neat thing about the way it was originally written, is that the Python
> script could be used stand-alone, so long as the test program was
> stopped in the right place you could source the Python script and it
> would do the right thing.
> 
> You proposed patch changes this slightly so that the .exp script is
> needed to setup some of the frame-id data.  That's absolutely fine, but
> can make the test harder to run outside DejaGNU; if the stack addresses
> change the user needs to figure out the updated values.  It's a really
> minor thing, but how about the patch below (still needs a commit
> message), but this does more of the work in the Python script again.

Hi Andrew,

I've taken your patch, and added a bit onto it:
- capture all available frame IDs: for frames #0 - #6.  Frame #6 was
   missing.
- print the captured frame IDs
- added a comment in TestUnwinder.__call__ that explains in detail what
   the normal behavior is, and how we're deviating from it to make the
   backtrace stop.
- added commit message

I've submitted this as a v2 ( 
https://sourceware.org/pipermail/gdb-patches/2026-January/224308.html ).

I hope my understanding of what the test-case is trying to do is correct 
now.

Thanks,
- Tom


  reply	other threads:[~2026-01-21 13:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11 13:39 Tom de Vries
2026-01-03 15:12 ` [PING][PATCH] " Tom de Vries
2026-01-19 18:36   ` [PING^2][PATCH] " Tom de Vries
2026-01-20 10:38 ` [PATCH] " Andrew Burgess
2026-01-20 14:30 ` Andrew Burgess
2026-01-20 20:38   ` Andrew Burgess
2026-01-21 13:09     ` Tom de Vries [this message]
2026-01-21 13:32   ` Tom de Vries
2026-01-21 16:50     ` Andrew Burgess
2026-01-24 23:19 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6ea6267-0548-462f-9e1f-cc1ea0454833@suse.de \
    --to=tdevries@suse.de \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox