From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LfXOKE/QcGniJw4AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 08:10:39 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZT2QQGtA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sjRXUOxs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZT2QQGtA; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sjRXUOxs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 994531E08D; Wed, 21 Jan 2026 08:10:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFF871E08D for ; Wed, 21 Jan 2026 08:10:38 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 524F34BC8974 for ; Wed, 21 Jan 2026 13:10:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 524F34BC8974 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZT2QQGtA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sjRXUOxs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZT2QQGtA; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sjRXUOxs Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 794114BC8970 for ; Wed, 21 Jan 2026 13:09:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 794114BC8970 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 794114BC8970 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769000990; cv=none; b=oC0aMPHkf6eU3fj+Z2s0HjvBUGqMA/Fv8ERy3qjPaE9mT0yUfL+s8+jyySaXf5IZtp3CC2CJNxoAO8G7LeB6agBWxF9pQ64ZragvL4dUH4pHPOwh69iW9/yplI9D4dND3iqGLkXaHFUvXvGnpiz5A0yAR8Do+U0HSyVenBfHP08= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769000990; c=relaxed/simple; bh=eqtKtoKi4JSOdWxRGnRVB9scA2bEhgkmY2e5Aa0eXwo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=TJpTWHesxKMTyGUTZHgfqBW311Zq6RSBLnVCLXL53YiK9kRo0nWyzWvMEtt6O6WdjKiLTytaBqGhsqKnEqP88AbZ9T88JVVFkB0OC9Dr0ZBcIXheaqWOCKt4Aj1MJxQrajfeGMCyuHLFGWStgi7fVjUbLrtcRJ+WhFysa7lJmSk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 794114BC8970 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5EBF23369D; Wed, 21 Jan 2026 13:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769000989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LaS1daPjk4J3W8Dh0Ayc9t3NU/uatUTGvJP5Hx9KkCU=; b=ZT2QQGtAYbxy3q+norLj9l3uYmae5bes2LYxHxtmYWBPhYIigt8yMugrO8VLRXBrXTw07J qrxN+ZnK18S2daLSNoA9WcHu8+nq+LF8lVT6+M/SGP1U0Y6ImYZ6r2r+5k8XA/zSSbo8E4 MeyKJKMa4RyrXZXdsy34QV0Ds3QJ5Bg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769000989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LaS1daPjk4J3W8Dh0Ayc9t3NU/uatUTGvJP5Hx9KkCU=; b=sjRXUOxsNE8Ncl/6leUJGGyhWxgiTKEPJDJ/szLANdwpzgaI9Dd/T0vHVjNjHTA9Q0Gjs+ mZ3JlF+0XE2sFFAg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZT2QQGtA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sjRXUOxs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769000989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LaS1daPjk4J3W8Dh0Ayc9t3NU/uatUTGvJP5Hx9KkCU=; b=ZT2QQGtAYbxy3q+norLj9l3uYmae5bes2LYxHxtmYWBPhYIigt8yMugrO8VLRXBrXTw07J qrxN+ZnK18S2daLSNoA9WcHu8+nq+LF8lVT6+M/SGP1U0Y6ImYZ6r2r+5k8XA/zSSbo8E4 MeyKJKMa4RyrXZXdsy34QV0Ds3QJ5Bg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769000989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LaS1daPjk4J3W8Dh0Ayc9t3NU/uatUTGvJP5Hx9KkCU=; b=sjRXUOxsNE8Ncl/6leUJGGyhWxgiTKEPJDJ/szLANdwpzgaI9Dd/T0vHVjNjHTA9Q0Gjs+ mZ3JlF+0XE2sFFAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 48FBB3EA65; Wed, 21 Jan 2026 13:09:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BfuIEB3QcGkdHAAAD6G6ig (envelope-from ); Wed, 21 Jan 2026 13:09:49 +0000 Message-ID: Date: Wed, 21 Jan 2026 14:09:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.base/inline-frame-cycle-unwind.exp for s390x (alternative) To: Andrew Burgess , gdb-patches@sourceware.org References: <20251211133946.962934-1-tdevries@suse.de> <87a4y8qru0.fsf@redhat.com> <877btchvf2.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <877btchvf2.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 5EBF23369D X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/20/26 9:38 PM, Andrew Burgess wrote: > Having spent some time now running and debugging this test, I think one > neat thing about the way it was originally written, is that the Python > script could be used stand-alone, so long as the test program was > stopped in the right place you could source the Python script and it > would do the right thing. > > You proposed patch changes this slightly so that the .exp script is > needed to setup some of the frame-id data. That's absolutely fine, but > can make the test harder to run outside DejaGNU; if the stack addresses > change the user needs to figure out the updated values. It's a really > minor thing, but how about the patch below (still needs a commit > message), but this does more of the work in the Python script again. Hi Andrew, I've taken your patch, and added a bit onto it: - capture all available frame IDs: for frames #0 - #6. Frame #6 was missing. - print the captured frame IDs - added a comment in TestUnwinder.__call__ that explains in detail what the normal behavior is, and how we're deviating from it to make the backtrace stop. - added commit message I've submitted this as a v2 ( https://sourceware.org/pipermail/gdb-patches/2026-January/224308.html ). I hope my understanding of what the test-case is trying to do is correct now. Thanks, - Tom