From: Simon Marchi <simark@simark.ca>
To: George Barrett <bob@bob131.so>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix scripted probe breakpoints
Date: Mon, 09 Dec 2019 21:54:00 -0000 [thread overview]
Message-ID: <f6bf78f0-a47c-c558-ac7a-39ca61beb6dd@simark.ca> (raw)
In-Reply-To: <mvtikg5f9d7hqbm-cro5b2ygqg-b9e44xho-k1cdn0.k49xmwvti@mail.bob131.so>
On 2019-12-09 4:43 p.m., George Barrett wrote:
> On Mon, Dec 09, 2019 at 04:37:47PM -0500, Simon Marchi wrote:
>> so would you like me to push the patch on your behalf?
>
> Yes, please.
Done.
>> I found some other really small nits, I'll fix them before pushing if I end
>> up pushing for you.
>
>> I missed this last time, but also in GNU style we compare pointers and
>> integers explicitly, so either one of these would be good:
>
>> I would change null to NULL or nullptr to match the language nomenclature.
>
>> non-zero -> true
>
> I appreciate the tips, sorry for the additional round-trips.
>
> Thank you for your patience and speedy review!
No worries, you have clearly made an effort to follow the guidelines, which made
it very painless.
Simon
prev parent reply other threads:[~2019-12-09 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:28 George Barrett
2019-12-09 21:37 ` Simon Marchi
2019-12-09 21:43 ` George Barrett
2019-12-09 21:54 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6bf78f0-a47c-c558-ac7a-39ca61beb6dd@simark.ca \
--to=simark@simark.ca \
--cc=bob@bob131.so \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox