From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79706 invoked by alias); 9 Dec 2019 21:54:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79656 invoked by uid 89); 9 Dec 2019 21:54:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2019 21:54:02 +0000 Received: from [132.207.245.28] (Sansfil-Securise-Etudiants-Lassonde-245-28.polymtl.ca [132.207.245.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D29AD1E08E; Mon, 9 Dec 2019 16:54:00 -0500 (EST) Subject: Re: [PATCH v2] Fix scripted probe breakpoints To: George Barrett Cc: gdb-patches@sourceware.org References: From: Simon Marchi Message-ID: Date: Mon, 09 Dec 2019 21:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00363.txt.bz2 On 2019-12-09 4:43 p.m., George Barrett wrote: > On Mon, Dec 09, 2019 at 04:37:47PM -0500, Simon Marchi wrote: >> so would you like me to push the patch on your behalf? > > Yes, please. Done. >> I found some other really small nits, I'll fix them before pushing if I end >> up pushing for you. > >> I missed this last time, but also in GNU style we compare pointers and >> integers explicitly, so either one of these would be good: > >> I would change null to NULL or nullptr to match the language nomenclature. > >> non-zero -> true > > I appreciate the tips, sorry for the additional round-trips. > > Thank you for your patience and speedy review! No worries, you have clearly made an effort to follow the guidelines, which made it very painless. Simon