Re: [PATCH] gdb/dwarf: turn some errors into asserts

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2026-02-02 12:42, Kevin Buettner wrote:
> On Mon, 26 Jan 2026 12:01:17 -0500
> Simon Marchi <simon.marchi@efficios.com> wrote:
> 
>> From: Simon Marchi <simon.marchi@efficios.com>
>> To: gdb-patches@sourceware.org
>> Cc: Simon Marchi <simon.marchi@polymtl.ca>
>> Subject: [PATCH] gdb/dwarf: turn some errors into asserts
>> Date: Mon, 26 Jan 2026 12:01:17 -0500
>>
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> There are some nullptr checks on the return value of load_cu that I
>> think can't possibly ever be true.  load_cu returns nullptr only if the
>> CU is "dummy".  A "dummy" CU is one that has a header but no DIE.  The
>> body (the part after the header, included in the unit reported by the
>> header) is either empty or consists only of zeroes (null entries).
>>
>> In the various spots I modified we are doing some work (e.g. evaluating an
>> expression) in the context of PER_CU, so PER_CU can't possibly be empty
>> / dummy.
>>
>> Change those conditions to asserts.  No behavior change expected, unless
>> my reasoning is incorrect.
> 
> I agree with your reasoning.
> 
> Approved-by: Kevin Buettner <kevinb@redhat.com>
> 

Pushed, thanks!

Simon