From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mLuvONDpgGmPlCQAWB0awg (envelope-from ) for ; Mon, 02 Feb 2026 13:15:44 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=sweWPZMD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D98581E08D; Mon, 02 Feb 2026 13:15:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C0A9E1E08D for ; Mon, 02 Feb 2026 13:15:43 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2C4E44BB592C for ; Mon, 2 Feb 2026 18:15:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C4E44BB592C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=sweWPZMD Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BF9D34BA903E for ; Mon, 2 Feb 2026 18:15:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF9D34BA903E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF9D34BA903E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770056111; cv=none; b=Ut9lJcXzpgx5T2vzhzhxMfYC/pVy7QYOyt8B/N6DhMxIq+69To2BbP507CmuJXfY2uxOfcklYD9AVsDmCrwNrZPkMQpsMJ3vDBnpClJzGgeveyUrEmAI9g+FgnODTAUNSRZwZ795eNYrZiSd7QY9LaYIcJPRLL/JwwtUW3OZAZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770056111; c=relaxed/simple; bh=oTCCda4TTQPgfQuwx0j4w0ibDi7iVeR9eDNwDXGR4Gg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kCPgmyFZ7U089ap2yvfGjCBB6ib7amxHUNYtnD/dDmLJ47IYQRbVKh2msyKYGLJVcmo/ZQtsHnLL5142NPr5SaMKCKifiPZbH6GKhop6D8wKggvFyqUanxilalMkIxKwOp1fXzuBYgAvedKAoKlxF5ZdPD2RLfJYTA7via9bzUM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF9D34BA903E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 612IF2bs226015 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Feb 2026 13:15:07 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 612IF2bs226015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770056107; bh=dk9+QZ0P3VXbw03b8XhFoDwFGNzdEzxvnBRbT/yWTbo=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=sweWPZMDZgQR3+/N9Mb8gKsb3G8PEjNSg2Shh9BD+b4X4mqASbkbniTFZHs0VMSS3 wNpi+lWWw9ctSvE9ZMskoE59swPqMNe8fmqgxAc5sjSxyabXzLorBmzX1Km1Na/FsI /6MhTo4S0cYtG5Sm/kYxV6UaWsR3p8iv703q+vUNUqKbNxniVUzZfXjV82h+h1F265 kP1aikBIhAL2mnIQdHzhhDRHyrjt9ycwYJ8DVmBOIfZvSI1bstJaRI1ftBcYQwBrGj gpL+5Ps0AH+ib8wpgjmyC+I8844wYMg4tIfz/IKXKQCoLqM8fkMa8esHYU1JfasKAw dfwIQe7QbagTA== Received: by simark.ca (Postfix) id E1A481E08D; Mon, 02 Feb 2026 13:15:01 -0500 (EST) Message-ID: Date: Mon, 2 Feb 2026 13:15:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf: turn some errors into asserts To: Kevin Buettner , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260126170120.268777-1-simon.marchi@efficios.com> <20260202104218.7aa08244@f42-mesa-1> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260202104218.7aa08244@f42-mesa-1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 2 Feb 2026 18:15:02 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-02 12:42, Kevin Buettner wrote: > On Mon, 26 Jan 2026 12:01:17 -0500 > Simon Marchi wrote: > >> From: Simon Marchi >> To: gdb-patches@sourceware.org >> Cc: Simon Marchi >> Subject: [PATCH] gdb/dwarf: turn some errors into asserts >> Date: Mon, 26 Jan 2026 12:01:17 -0500 >> >> From: Simon Marchi >> >> There are some nullptr checks on the return value of load_cu that I >> think can't possibly ever be true. load_cu returns nullptr only if the >> CU is "dummy". A "dummy" CU is one that has a header but no DIE. The >> body (the part after the header, included in the unit reported by the >> header) is either empty or consists only of zeroes (null entries). >> >> In the various spots I modified we are doing some work (e.g. evaluating an >> expression) in the context of PER_CU, so PER_CU can't possibly be empty >> / dummy. >> >> Change those conditions to asserts. No behavior change expected, unless >> my reasoning is incorrect. > > I agree with your reasoning. > > Approved-by: Kevin Buettner > Pushed, thanks! Simon