From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Remove LANG_MAGIC
Date: Fri, 12 Apr 2019 04:37:00 -0000 [thread overview]
Message-ID: <f506b8b0-9f2f-18c7-3e71-1c4ef179e1d9@simark.ca> (raw)
In-Reply-To: <20190411232350.27832-1-andrew.burgess@embecosm.com>
On 2019-04-11 7:23 p.m., Andrew Burgess wrote:
> The language_defn structure has an la_magic field, this used to be
> used as a basic check that the language_defn structure had the
> expected layout - at least the end of the structure was where we
> expected it to be.
>
> This feature only really makes sense if we imagine GDB dynamically
> loading language support from dynamic libraries, where a version
> mismatch might cause problems.
>
> However, in current GDB language support is statically built into GDB,
> and since this commit:
>
> commit 47e77640be31fc1a4eb3718f594ed5fd0faff065
> Date: Thu Jul 20 18:28:01 2017 +0100
>
> Make language_def O(1)
>
> the existing (if pointless) check of the la_magic field was removed.
>
> There now appears to be no use of the la_magic field, and I propose
> that we delete it.
>
> There should be no user visible changes after this commit.
Given that nothing even checks it, this LGTM.
Simon
next prev parent reply other threads:[~2019-04-12 4:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 23:24 Andrew Burgess
2019-04-12 4:37 ` Simon Marchi [this message]
2019-04-12 9:50 ` Pedro Alves
[not found] ` <20190412110812.GE2737@embecosm.com>
2019-04-12 11:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f506b8b0-9f2f-18c7-3e71-1c4ef179e1d9@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox