From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73732 invoked by alias); 12 Apr 2019 04:37:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73717 invoked by uid 89); 12 Apr 2019 04:37:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Apr 2019 04:37:17 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2C3991E0A9; Fri, 12 Apr 2019 00:37:15 -0400 (EDT) Subject: Re: [PATCH] gdb: Remove LANG_MAGIC To: Andrew Burgess , gdb-patches@sourceware.org References: <20190411232350.27832-1-andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: Date: Fri, 12 Apr 2019 04:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190411232350.27832-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00216.txt.bz2 On 2019-04-11 7:23 p.m., Andrew Burgess wrote: > The language_defn structure has an la_magic field, this used to be > used as a basic check that the language_defn structure had the > expected layout - at least the end of the structure was where we > expected it to be. > > This feature only really makes sense if we imagine GDB dynamically > loading language support from dynamic libraries, where a version > mismatch might cause problems. > > However, in current GDB language support is statically built into GDB, > and since this commit: > > commit 47e77640be31fc1a4eb3718f594ed5fd0faff065 > Date: Thu Jul 20 18:28:01 2017 +0100 > > Make language_def O(1) > > the existing (if pointless) check of the la_magic field was removed. > > There now appears to be no use of the la_magic field, and I propose > that we delete it. > > There should be no user visible changes after this commit. Given that nothing even checks it, this LGTM. Simon