* [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself
@ 2023-10-26 0:47 Thiago Jung Bauermann
2023-10-26 8:18 ` Luis Machado
0 siblings, 1 reply; 4+ messages in thread
From: Thiago Jung Bauermann @ 2023-10-26 0:47 UTC (permalink / raw)
To: gdb-patches
GCC doesn't complain, but it's still wrong.
---
gdb/nat/aarch64-scalable-linux-ptrace.h | 1 -
1 file changed, 1 deletion(-)
I just spotted the problem, and pushed this patch to fix it under the
obvious rule.
diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h b/gdb/nat/aarch64-scalable-linux-ptrace.h
index 69c9982b0096..8ff2a96ceb16 100644
--- a/gdb/nat/aarch64-scalable-linux-ptrace.h
+++ b/gdb/nat/aarch64-scalable-linux-ptrace.h
@@ -32,7 +32,6 @@
#include <sys/ptrace.h>
#include <asm/ptrace.h>
#include <stdarg.h>
-#include "aarch64-scalable-linux-ptrace.h"
#include "aarch64-scalable-linux-sigcontext.h"
/* Indicates whether a SVE ptrace header is followed by SVE registers or a
base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself
2023-10-26 0:47 [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself Thiago Jung Bauermann
@ 2023-10-26 8:18 ` Luis Machado
2023-10-26 13:23 ` Thiago Jung Bauermann
0 siblings, 1 reply; 4+ messages in thread
From: Luis Machado @ 2023-10-26 8:18 UTC (permalink / raw)
To: Thiago Jung Bauermann, gdb-patches
On 10/26/23 01:47, Thiago Jung Bauermann wrote:
> GCC doesn't complain, but it's still wrong.
> ---
> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 -
> 1 file changed, 1 deletion(-)
>
> I just spotted the problem, and pushed this patch to fix it under the
> obvious rule.
>
> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h b/gdb/nat/aarch64-scalable-linux-ptrace.h
> index 69c9982b0096..8ff2a96ceb16 100644
> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h
> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h
> @@ -32,7 +32,6 @@
> #include <sys/ptrace.h>
> #include <asm/ptrace.h>
> #include <stdarg.h>
> -#include "aarch64-scalable-linux-ptrace.h"
> #include "aarch64-scalable-linux-sigcontext.h"
>
> /* Indicates whether a SVE ptrace header is followed by SVE registers or a
>
> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e
Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself
2023-10-26 8:18 ` Luis Machado
@ 2023-10-26 13:23 ` Thiago Jung Bauermann
2023-10-26 13:24 ` Luis Machado
0 siblings, 1 reply; 4+ messages in thread
From: Thiago Jung Bauermann @ 2023-10-26 13:23 UTC (permalink / raw)
To: Luis Machado; +Cc: gdb-patches
Hello Luis,
Luis Machado <luis.machado@arm.com> writes:
> On 10/26/23 01:47, Thiago Jung Bauermann wrote:
>> GCC doesn't complain, but it's still wrong.
>> ---
>> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> I just spotted the problem, and pushed this patch to fix it under the
>> obvious rule.
>>
>> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h
>> b/gdb/nat/aarch64-scalable-linux-ptrace.h
>> index 69c9982b0096..8ff2a96ceb16 100644
>> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h
>> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h
>> @@ -32,7 +32,6 @@
>> #include <sys/ptrace.h>
>> #include <asm/ptrace.h>
>> #include <stdarg.h>
>> -#include "aarch64-scalable-linux-ptrace.h"
>> #include "aarch64-scalable-linux-sigcontext.h"
>>
>> /* Indicates whether a SVE ptrace header is followed by SVE registers or a
>>
>> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e
>
> Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14.
Good idea. I just pushed to gdb-14-branch.
--
Thiago
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself
2023-10-26 13:23 ` Thiago Jung Bauermann
@ 2023-10-26 13:24 ` Luis Machado
0 siblings, 0 replies; 4+ messages in thread
From: Luis Machado @ 2023-10-26 13:24 UTC (permalink / raw)
To: Thiago Jung Bauermann; +Cc: gdb-patches
On 10/26/23 14:23, Thiago Jung Bauermann wrote:
>
> Hello Luis,
>
> Luis Machado <luis.machado@arm.com> writes:
>
>> On 10/26/23 01:47, Thiago Jung Bauermann wrote:
>>> GCC doesn't complain, but it's still wrong.
>>> ---
>>> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> I just spotted the problem, and pushed this patch to fix it under the
>>> obvious rule.
>>>
>>> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h
>>> b/gdb/nat/aarch64-scalable-linux-ptrace.h
>>> index 69c9982b0096..8ff2a96ceb16 100644
>>> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h
>>> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h
>>> @@ -32,7 +32,6 @@
>>> #include <sys/ptrace.h>
>>> #include <asm/ptrace.h>
>>> #include <stdarg.h>
>>> -#include "aarch64-scalable-linux-ptrace.h"
>>> #include "aarch64-scalable-linux-sigcontext.h"
>>>
>>> /* Indicates whether a SVE ptrace header is followed by SVE registers or a
>>>
>>> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e
>>
>> Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14.
>
> Good idea. I just pushed to gdb-14-branch.
>
Great. Thanks for chasing this.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-26 13:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-26 0:47 [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself Thiago Jung Bauermann
2023-10-26 8:18 ` Luis Machado
2023-10-26 13:23 ` Thiago Jung Bauermann
2023-10-26 13:24 ` Luis Machado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox