Re: [PATCH] Add MI "-break-insert --qualified"

[Pedro Alves <pedro@palves.net>]

On 9/2/20 7:35 PM, Simon Marchi wrote:
> On 2020-09-01 2:07 p.m., Pedro Alves wrote:
>> Currently -break-insert always creates a wildmatching breakpoint, and
>> there's no way to ask for a fullname match.  To address that, this
>> patch adds the equivalent of "break -qualified" to MI:
>>
>>   "-break-insert --qualified".
>>
>> For the testcase, curiously, it doesn't look like we have _any_
>> testcase that tests a breakpoint with multiple locations, and, the
>> existing mi_create_breakpoint / mi_make_breakpoint procedures are only
>> good for breakpoints with a single location.  This patch thus adds a
>> few new companion routines to mi-support.exp for breakpoints with
>> multiple locations: mi_create_breakpoint_multi,
>> mi_make_breakpoint_loc, mi_make_breakpoint_multi.
> 
> The code looks good to me.
> 

Thank you both.

I've merged this now, with NEWS entry moved to the new
"Changes since GDB 10" section.

Pedro Alves