From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by sourceware.org (Postfix) with ESMTPS id B08833857C5A for ; Sun, 13 Sep 2020 17:13:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B08833857C5A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f66.google.com with SMTP id l15so4400440wmh.1 for ; Sun, 13 Sep 2020 10:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lelptXgNEQl3fqa6CuR0f+UozrdA8/Pr4E8GJtglOYE=; b=jho8L4dQUv+qvrGjU1HEznK+sarp7a+aBLS7thK3jBV0EiemFcKW2sa4vagheMI9mi vAnQoJLivM5Zs+4DHlc8eihr7+RSIVCaA0PHoaOAmPwHebZ7sowAWjlat5LeCVGrj9tQ e+nccMQIfi9PK1fvZ+voC6dtBq6NrmOvuAzC4FMWMEHvtAABRKiNKciFiVAEgiKHwwEV sEvRhlwS6MWoppW7kOcenMbZLz4e6ZshmCEPtLLcq/tbu/k7bcUU/gZh61MgjkGGpjZa EfyrG8dAZMp8eqB2XnJr618ZwAn1SrX/KKCI51Rm7+n4G/BMDTwJx7fKXMxTWId072AK nueQ== X-Gm-Message-State: AOAM532jcyI3XYgfLn6HMlb8zcq4FVSXY6znkw6sHd/rnKxAU3uA/4Xa 6KbJoTLVzSimZPv9WgSyEA5oA6sGx0UCeQ== X-Google-Smtp-Source: ABdhPJxrGQ2mIpT8uUur+SEb7lHIty+qDwps1S7Nm7lchJ8So5v6s4KmN6KVTU+l2cYMZ4YABmoS2Q== X-Received: by 2002:a1c:7207:: with SMTP id n7mr11203124wmc.134.1600017204120; Sun, 13 Sep 2020 10:13:24 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:eefd:c63:53e0:3e8a? ([2001:8a0:f905:5600:eefd:c63:53e0:3e8a]) by smtp.gmail.com with ESMTPSA id 8sm16940924wrl.7.2020.09.13.10.13.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2020 10:13:23 -0700 (PDT) Subject: Re: [PATCH] Add MI "-break-insert --qualified" To: Simon Marchi , Eli Zaretskii References: <20200901180703.20045-1-pedro@palves.net> <619c2383-5a76-3be2-cf80-dd532195fa30@simark.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Sun, 13 Sep 2020 18:13:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <619c2383-5a76-3be2-cf80-dd532195fa30@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2020 17:13:27 -0000 On 9/2/20 7:35 PM, Simon Marchi wrote: > On 2020-09-01 2:07 p.m., Pedro Alves wrote: >> Currently -break-insert always creates a wildmatching breakpoint, and >> there's no way to ask for a fullname match. To address that, this >> patch adds the equivalent of "break -qualified" to MI: >> >> "-break-insert --qualified". >> >> For the testcase, curiously, it doesn't look like we have _any_ >> testcase that tests a breakpoint with multiple locations, and, the >> existing mi_create_breakpoint / mi_make_breakpoint procedures are only >> good for breakpoints with a single location. This patch thus adds a >> few new companion routines to mi-support.exp for breakpoints with >> multiple locations: mi_create_breakpoint_multi, >> mi_make_breakpoint_loc, mi_make_breakpoint_multi. > > The code looks good to me. > Thank you both. I've merged this now, with NEWS entry moved to the new "Changes since GDB 10" section. Pedro Alves