From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix "text file busy" errors with cc-with-tweaks.exp
Date: Fri, 06 Mar 2020 17:01:00 -0000 [thread overview]
Message-ID: <ef3e12ac-5479-a7dc-9b6c-c2ac1f2b013e@polymtl.ca> (raw)
In-Reply-To: <20200306114923.GA2185@delia>
On 2020-03-06 6:49 a.m., Tom de Vries wrote:
> Hi,
>
> When using target board cc-with-gdb-index.exp and running tests in parallel,
> we run into:
> ...
> gdb compile failed, gdb/contrib/gdb-add-index.sh: line 86: \
> build/gdb/testsuite/gdb.sh: Text file busy
> ...
>
> The problem is that because of the parallel test run, gdb.sh is created for
> every single test-case, and eventually gdb.sh is overwritten while being
> executed.
>
> Fix this by creating gdb.sh only once.
>
> Tested on x86_64-linux with target board cc-with-gdb-index.exp, using both a
> serial and parallel -j 5 test run.
>
> OK for trunk?
>
> Thanks,
> - Tom
Hi Tom,
Thanks for fixing this. I've tried a few runs of:
make check-parallel RUNTESTFLAGS="--target_board=cc-with-debug-names" TESTS="gdb.dwarf2/*.exp" -j 32
... and don't see any variations of this nature anymore (whereas I see some without the patch applied).
The patch LGTM.
Simon
prev parent reply other threads:[~2020-03-06 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 11:49 Tom de Vries
2020-03-06 17:01 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef3e12ac-5479-a7dc-9b6c-c2ac1f2b013e@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox