From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55114 invoked by alias); 6 Mar 2020 17:01:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55013 invoked by uid 89); 6 Mar 2020 17:01:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HDKIM-Filter:v2.11.0, HX-Languages-Length:1005 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 17:01:01 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 026H0rh7028527 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Mar 2020 12:00:58 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 026H0rh7028527 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1583514059; bh=lPKhh9EPJtYewSD9wGI9rXdzdWmgDTI0kXVld6NxaBY=; h=Subject:To:References:From:Date:In-Reply-To:From; b=NGn3CKS7QfhKguX3hLnrC+MeK6un0EQq8WwE/wR3qmjOyMHqMbsgSnoZyB792Hh1i ZpqXgoZ0fMbkqGlQ1tMKByG7MXCa3nhg9ztDor4mGzExEYJXrCmSXilHCcvxgn0G3A aSyNgyT1wdlXG/0hZ1nN9u1IJzaTkfLl5Kx+7Ue8= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 862CA1E581; Fri, 6 Mar 2020 12:00:53 -0500 (EST) Subject: Re: [PATCH][gdb/testsuite] Fix "text file busy" errors with cc-with-tweaks.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20200306114923.GA2185@delia> From: Simon Marchi Message-ID: Date: Fri, 06 Mar 2020 17:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200306114923.GA2185@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00146.txt On 2020-03-06 6:49 a.m., Tom de Vries wrote: > Hi, > > When using target board cc-with-gdb-index.exp and running tests in parallel, > we run into: > ... > gdb compile failed, gdb/contrib/gdb-add-index.sh: line 86: \ > build/gdb/testsuite/gdb.sh: Text file busy > ... > > The problem is that because of the parallel test run, gdb.sh is created for > every single test-case, and eventually gdb.sh is overwritten while being > executed. > > Fix this by creating gdb.sh only once. > > Tested on x86_64-linux with target board cc-with-gdb-index.exp, using both a > serial and parallel -j 5 test run. > > OK for trunk? > > Thanks, > - Tom Hi Tom, Thanks for fixing this. I've tried a few runs of: make check-parallel RUNTESTFLAGS="--target_board=cc-with-debug-names" TESTS="gdb.dwarf2/*.exp" -j 32 ... and don't see any variations of this nature anymore (whereas I see some without the patch applied). The patch LGTM. Simon