From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Fix language of duplicate static minimal symbol
Date: Wed, 07 Nov 2018 15:24:00 -0000 [thread overview]
Message-ID: <eedb5703619d1beb390f2b1404556c1d@polymtl.ca> (raw)
In-Reply-To: <b5867027-cc84-47fe-353e-6bbbb0ce96ea@suse.de>
On 2018-10-31 05:09, Tom de Vries wrote:
> I have a pre-commit script (for both gcc and gdb) that uses this
> format,
> and puts ChangeLog hunks in the correct ChangeLog file ( more detail
> here: https://sourceware.org/ml/gdb-patches/2018-06/msg00351.html ).
> Sofar this format has been acceptable for maintainers.
Yes, as long as they end up in the right file it's fine.
The patch LGTM too. Before, pushing could you just add a one liner
description in your .exp file? Something like:
# Test that when two symbols with the same linkage name are present in
the
# executable, they both get assigned the right language.
Thanks,
Simon
prev parent reply other threads:[~2018-11-07 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 19:11 Tom de Vries
2018-10-30 21:21 ` Keith Seitz
2018-10-31 9:09 ` Tom de Vries
2018-11-07 9:59 ` [PING][PATCH][gdb/symtab] " Tom de Vries
2018-11-07 15:24 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eedb5703619d1beb390f2b1404556c1d@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox