From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2233 invoked by alias); 7 Nov 2018 15:24:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2209 invoked by uid 89); 7 Nov 2018 15:24:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 15:24:02 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wA7FNtrt003009 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 7 Nov 2018 10:24:00 -0500 Received: by simark.ca (Postfix, from userid 112) id 5DBE01E514; Wed, 7 Nov 2018 10:23:55 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 52BD91E477; Wed, 7 Nov 2018 10:23:54 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 07 Nov 2018 15:24:00 -0000 From: Simon Marchi To: Tom de Vries Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/symtab] Fix language of duplicate static minimal symbol In-Reply-To: References: <20181030191142.GA13785@delia> <07e42727-0d74-7f04-ef7c-39e180f71da8@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00098.txt.bz2 On 2018-10-31 05:09, Tom de Vries wrote: > I have a pre-commit script (for both gcc and gdb) that uses this > format, > and puts ChangeLog hunks in the correct ChangeLog file ( more detail > here: https://sourceware.org/ml/gdb-patches/2018-06/msg00351.html ). > Sofar this format has been acceptable for maintainers. Yes, as long as they end up in the right file it's fine. The patch LGTM too. Before, pushing could you just add a one liner description in your .exp file? Something like: # Test that when two symbols with the same linkage name are present in the # executable, they both get assigned the right language. Thanks, Simon