Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Tom de Vries <tdevries@suse.de>
Cc: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp
Date: Fri, 02 Aug 2019 14:46:00 -0000	[thread overview]
Message-ID: <ee9ff58c-1ac5-4728-c11e-ae3d7fa88e35@simark.ca> (raw)
In-Reply-To: <87tvazisy8.fsf@tromey.com>

On 2019-08-02 9:43 a.m., Tom Tromey wrote:
> I'm reluctant to make the test suite more sensitive to the environment
> it's running it.  Is the reason to do this that the test can time out
> normally, and so we'd like to avoid lengthy timeouts?  If that's the
> case, can the test be fixed somehow instead?
> 
> I guess my mental model here is that a timeout should not matter unless
> a test is flaky.  But maybe that's naive?  I don't know :-)

No, the test is not expected to time out under normal circumstances.  The advantage
of having with_read1_timeout_factor is just that if we happen to break this test
and make it time out, we'll have to wait 10 seconds instead of 100 when running without
read1.

Given that the probability of breaking this test is very small, I don't have
a strong opinion on the matter, it doesn't affect the correctness of the testsuite.

Simon


  reply	other threads:[~2019-08-02 14:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 14:39 Simon Marchi
2019-08-01 18:18 ` Tom Tromey
2019-08-01 19:16   ` Simon Marchi
     [not found]     ` <cba4616c-4e3c-4217-7c7a-40fb576ea351@suse.de>
2019-08-02 13:43       ` Tom Tromey
2019-08-02 14:46         ` Simon Marchi [this message]
2019-08-05 13:58           ` Tom de Vries
2019-08-05 14:23             ` Simon Marchi
2019-08-05 13:53         ` Tom de Vries
2019-08-15 17:58 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee9ff58c-1ac5-4728-c11e-ae3d7fa88e35@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox