Re: [PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp

[Tom de Vries <tdevries@suse.de>]

On 02-08-19 16:46, Simon Marchi wrote:
> On 2019-08-02 9:43 a.m., Tom Tromey wrote:
>> I'm reluctant to make the test suite more sensitive to the environment
>> it's running it.  Is the reason to do this that the test can time out
>> normally, and so we'd like to avoid lengthy timeouts?  If that's the
>> case, can the test be fixed somehow instead?
>>
>> I guess my mental model here is that a timeout should not matter unless
>> a test is flaky.  But maybe that's naive?  I don't know :-)
> 
> No, the test is not expected to time out under normal circumstances.  The advantage
> of having with_read1_timeout_factor is just that if we happen to break this test
> and make it time out, we'll have to wait 10 seconds instead of 100 when running without
> read1.
> 
> Given that the probability of breaking this test is very small, I don't have
> a strong opinion on the matter, it doesn't affect the correctness of the testsuite.

I went ahead and committed a patch introducing with_read1_timeout_factor
( https://sourceware.org/ml/gdb-patches/2019-08/msg00107.html ).

Simon, can you commit your patch, fixing both mi_gdb_tests?

Thanks,
- Tom