Re: [PATCH] [gdb/contrib] Handle capitalized words in spellcheck.sh

[Tom de Vries <tdevries@suse.de>]

On 11/13/24 21:37, Kevin Buettner wrote:
> On Wed, 13 Nov 2024 02:08:52 +0100
> Tom de Vries <tdevries@suse.de> wrote:
> 
>> The dictionary contains a few entries with capital letters:
>> ...
>> $ grep -E '[A-Z]' .git/wikipedia-common-misspellings.txt | wc -l
>> 143
>> ...
>> but they don't look too interesting in the gdb context (for instance,
>> Habsbourg->Habsburg), so filter them out.
>>
>> That leaves us with entries looking only like "foobat->foobar", so add
>> handling of capitalized words, such that we also rewrite "Foobat" to "Foobar".
> 
> ...
> 
> -	pat=$(grep_join "${words[@]}")
> +	declare -a re_words
> +	mapfile -t re_words \
> +		< <(for f in "${words[@]}"; do
> +			echo "$f"
> +		    done \
> +			| sed "s/^\(.\)/[\u\1\1]/")
> +
> +	pat=$(grep_join "${re_words[@]}")
> 
> It took me a while to puzzle out that process substitution is being
> used to provide input to the mapfile command, but once I figured that
> out, it made sense to me.
> 
> Approved-by: Kevin Buettner <kevinb@redhat.com>

Thanks for the review, pushed.

- Tom