From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1DRVI2ccNWd83DAAWB0awg (envelope-from ) for ; Wed, 13 Nov 2024 16:38:47 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K5bbs8+l; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yD5xWiB+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=LLHW3pww; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Kjx38wGp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6619C1E170; Wed, 13 Nov 2024 16:38:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 393631E15F for ; Wed, 13 Nov 2024 16:38:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 593073858C53 for ; Wed, 13 Nov 2024 21:38:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 593073858C53 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K5bbs8+l; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yD5xWiB+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=LLHW3pww; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Kjx38wGp Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 4C4043858D29 for ; Wed, 13 Nov 2024 21:38:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C4043858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C4043858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731533892; cv=none; b=vR+Zl0/zutiffzj6sbFbeDZgI9TwlvbBi5S6cEF2JpDwsAahrRkJF8OPIpeTlbGJbS4RGJaPnd+p+6o+Za36K5W9fRCuiBVc28ugjpTX06jCtljFpoXkx/5F9K3wgF895vHAk4Dj1r0ya/zfG/188jBvIz9Aav2FOMdZOHOQSZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731533892; c=relaxed/simple; bh=WBs0/pmpDe/c1bVth66RLTI0aPvTFhvWT99ASuyDYNI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=KwQlO71gA6c78J1VlbpBB0cL7VolomEr9RJp7icWBNErnd2t7G+1AfuR56cNQL3CxpJZznRX9IKTqKVeoPto92ABARLPQXNbnKy94m1IqDVrP37MzfZt35v1YfOUlY8NN6jKYEtp0gHSuTBeBKcgIcn1/uk7vvSxfXAkgOFPlGg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C4043858D29 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 130AD1F7B3; Wed, 13 Nov 2024 21:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731533891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X9bgoko84lTtm+NMo8zRmZIMtGih6vTI6C8QpJ+2/Z0=; b=K5bbs8+lzMBQ2hiUfLy4scsoWWBOTUTnn5UPAwhenJO7qXZ61XeGWeqJH9THYWPS/TwwJ8 NNLT4ZTpuFwZy84/bkH7qHtKJNmBN3ySSalk5G6bSeJpy6gnOKoaeLf548Cn1axqV2ApD8 jOc7PWEgvBU1gajdivfuLLlFnr3gyNU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731533891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X9bgoko84lTtm+NMo8zRmZIMtGih6vTI6C8QpJ+2/Z0=; b=yD5xWiB+4V0WfC/9TqL+H4cC4wGvEG0iR9/u/F+st9ParAoyi1DBZmS9+MnGKJFa1n13ds YKws451B2kyza1Cg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LLHW3pww; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Kjx38wGp DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731533890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X9bgoko84lTtm+NMo8zRmZIMtGih6vTI6C8QpJ+2/Z0=; b=LLHW3pww1zd1tQscUCruGPeDvT9g/P4dhi8j1DWMIEmqOQZ2s5z69rE1VEOrwlGkstZ/cn Bhy9yG3bCoohIEPY6lM+8n3Zz2p5uxJvB/YEWnSm/PthHCWKTiNSrh43OW8a6sBgh6He2s ZlECKncrrfGuLggkiqDKjbhRTrz5KkE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731533890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X9bgoko84lTtm+NMo8zRmZIMtGih6vTI6C8QpJ+2/Z0=; b=Kjx38wGpewkWcxuYe/RI0TGraBNK8XhdP3HutQpNBz/FApnyF8qqrACEXT/fBP4EGj1zSW BTOloUXc8vLzthAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E297513301; Wed, 13 Nov 2024 21:38:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EhqlNUEcNWdsEgAAD6G6ig (envelope-from ); Wed, 13 Nov 2024 21:38:09 +0000 Message-ID: Date: Wed, 13 Nov 2024 22:38:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/contrib] Handle capitalized words in spellcheck.sh To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20241113010852.13952-1-tdevries@suse.de> <20241113133722.52c198f4@f40-zbm-amd> Content-Language: en-US From: Tom de Vries In-Reply-To: <20241113133722.52c198f4@f40-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 130AD1F7B3 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:dkim, suse.de:mid, suse.de:email] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/13/24 21:37, Kevin Buettner wrote: > On Wed, 13 Nov 2024 02:08:52 +0100 > Tom de Vries wrote: > >> The dictionary contains a few entries with capital letters: >> ... >> $ grep -E '[A-Z]' .git/wikipedia-common-misspellings.txt | wc -l >> 143 >> ... >> but they don't look too interesting in the gdb context (for instance, >> Habsbourg->Habsburg), so filter them out. >> >> That leaves us with entries looking only like "foobat->foobar", so add >> handling of capitalized words, such that we also rewrite "Foobat" to "Foobar". > > ... > > - pat=$(grep_join "${words[@]}") > + declare -a re_words > + mapfile -t re_words \ > + < <(for f in "${words[@]}"; do > + echo "$f" > + done \ > + | sed "s/^\(.\)/[\u\1\1]/") > + > + pat=$(grep_join "${re_words[@]}") > > It took me a while to puzzle out that process substitution is being > used to provide input to the mapfile command, but once I figured that > out, it made sense to me. > > Approved-by: Kevin Buettner Thanks for the review, pushed. - Tom