Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Chris Genly <chgenly@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: gdb.texinfo patch for -var-list-children (2)
Date: Sat, 20 Jun 2009 20:31:00 -0000	[thread overview]
Message-ID: <ed4903890906201330p90cac37p197274c5e5bd1162@mail.gmail.com> (raw)
In-Reply-To: <E1MI2L4-0006C5-5u@fencepost.gnu.org>

I'll submit a new patch based on your comments.  I appreciate you
spending your time on these changes.


>> + @anchor{-var-info-num-children}
>
> Why did you add this @anchor?  I don't see it referenced anywhere in
> your changes.

I'll fix that.

>> + For C/C++ structures there are several psuedo children returned to
>                                           ^^^^^^

You are pointing to the word "there".  I believe "there" is correct.
Are you thinking it should b e "their"?

> A typo.

> Also, please use "C@t{++}" instead of just "C++", the former looks
> better in print.

Ah. Good.

> Okay with these corrections.
>
> Btw, you seem to have no copyright assignment on file with the FSF,
> and your grace of 15 lines of contributions without an assignment is
> almost exhausted.  Did you start your paperwork with FSF?  If not,
> please consider doing that soon, or else we will be unable to accept
> your contributions.

I wasn't aware of the need for paperwork.  I appreciate you guiding me
through this.  I should have been aware.  I read
http://sourceware.org/cgi-bin/cvsweb.cgi/~checkout~/src/gdb/CONTRIBUTE?content-type=text/x-cvsweb-markup&cvsroot=src
document.  But I skimmed some sections.

I have filled out the request-assign.future document and sent it in.


  reply	other threads:[~2009-06-20 20:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20  4:11 Chris Genly
2009-06-20  8:45 ` Vladimir Prus
2009-06-20 10:01   ` Eli Zaretskii
2009-06-22  3:18     ` Joel Brobecker
2009-06-22  4:42       ` Eli Zaretskii
2009-06-22 15:02         ` Daniel Jacobowitz
2009-06-23  1:00           ` Eli Zaretskii
2009-06-23  3:19             ` Daniel Jacobowitz
2009-06-20 15:18 ` Eli Zaretskii
2009-06-20 20:31   ` Chris Genly [this message]
2009-06-20 21:33     ` Chris Genly
2009-07-04 12:13       ` Eli Zaretskii
2009-06-20 23:12     ` Eli Zaretskii
2009-06-20 23:17     ` Samuel Bronson
2009-06-21 19:28       ` Chris Genly
2009-06-21 23:12         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed4903890906201330p90cac37p197274c5e5bd1162@mail.gmail.com \
    --to=chgenly@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox