From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15755 invoked by alias); 20 Jun 2009 20:31:08 -0000 Received: (qmail 15746 invoked by uid 22791); 20 Jun 2009 20:31:07 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from yw-out-1718.google.com (HELO yw-out-1718.google.com) (74.125.46.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Jun 2009 20:31:00 +0000 Received: by yw-out-1718.google.com with SMTP id 4so1102543ywq.48 for ; Sat, 20 Jun 2009 13:30:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.17 with SMTP id b17mr5761836ane.45.1245529857972; Sat, 20 Jun 2009 13:30:57 -0700 (PDT) In-Reply-To: References: Date: Sat, 20 Jun 2009 20:31:00 -0000 Message-ID: Subject: Re: gdb.texinfo patch for -var-list-children (2) From: Chris Genly To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00536.txt.bz2 I'll submit a new patch based on your comments. I appreciate you spending your time on these changes. >> + @anchor{-var-info-num-children} > > Why did you add this @anchor? =A0I don't see it referenced anywhere in > your changes. I'll fix that. >> + For C/C++ structures there are several psuedo children returned to > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 ^^^^^^ You are pointing to the word "there". I believe "there" is correct. Are you thinking it should b e "their"? > A typo. > Also, please use "C@t{++}" instead of just "C++", the former looks > better in print. Ah. Good. > Okay with these corrections. > > Btw, you seem to have no copyright assignment on file with the FSF, > and your grace of 15 lines of contributions without an assignment is > almost exhausted. =A0Did you start your paperwork with FSF? =A0If not, > please consider doing that soon, or else we will be unable to accept > your contributions. I wasn't aware of the need for paperwork. I appreciate you guiding me through this. I should have been aware. I read http://sourceware.org/cgi-bin/cvsweb.cgi/~checkout~/src/gdb/CONTRIBUTE?cont= ent-type=3Dtext/x-cvsweb-markup&cvsroot=3Dsrc document. But I skimmed some sections. I have filled out the request-assign.future document and sent it in.