From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, Jerome Guitton <guitton@adacore.com>
Cc: Yao Qi <qiyaoltc@gmail.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
<gdb-patches@sourceware.org>
Subject: Re: [RFA] candidates for ambiguous command in upper case
Date: Tue, 17 Jan 2017 17:13:00 -0000 [thread overview]
Message-ID: <ed3637d6-0571-b7fc-c9ba-d3b635f07435@codesourcery.com> (raw)
In-Reply-To: <95bcfead-6b1a-305c-5064-0ffe961ca5f0@redhat.com>
On 01/17/2017 11:04 AM, Pedro Alves wrote:
> On 01/17/2017 04:51 PM, Luis Machado wrote:
>> On 01/17/2017 10:34 AM, Pedro Alves wrote:
>>> On 01/17/2017 04:29 PM, Luis Machado wrote:
>>>>
>>>> I don't see a problem with #1 as long as we keep it consistent
>>>> throughout from now on.
>>>
>>> Can you expand on exactly what you mean by the "as long" part?
>
>> Meaning that, if we go with #1, we should make sure we are not doing
>> case-insensitive comparisons in gdb unless it is clearly stated we
>> should do it (like handling of Windows paths i suppose).
>
> Would you say that we should stop completing "handle sig" to "handle SIG"?
> "handle" doesn't accept lowercase signal names, but it could be
> argued that the completer is helping the user here.
>
That sounds like a one-off case where it is useful.
> Grepping for strncasecmp doesn't find all that many hits, and several
> are in symbol lookup or path handling stuff where they're probably rightly
> used.
>
I'll go through the code to see if there are any other occurrences.
> The ones in tracepoint.c do look like of the inconsistent-user-interface sort.
> I had never realized we accept $REG etc. in tracepoint actions.
>
Neither did i. This one looks like it could be dropped.
next prev parent reply other threads:[~2017-01-17 17:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1484058324-5368-1-git-send-email-guitton@adacore.com>
2017-01-10 15:07 ` Yao Qi
2017-01-10 15:19 ` Jerome Guitton
2017-01-10 15:28 ` Simon Marchi
2017-01-10 15:40 ` Jerome Guitton
2017-01-10 17:00 ` Pedro Alves
2017-01-11 15:37 ` Jerome Guitton
2017-01-11 17:26 ` Yao Qi
2017-01-11 17:35 ` Luis Machado
2017-01-11 20:24 ` Pedro Alves
2017-01-12 10:18 ` Jerome Guitton
2017-01-12 16:37 ` Pedro Alves
2017-01-16 16:32 ` Jerome Guitton
2017-01-17 1:58 ` Pedro Alves
2017-01-17 16:29 ` Luis Machado
2017-01-17 16:35 ` Pedro Alves
2017-01-17 16:51 ` Luis Machado
2017-01-17 17:04 ` Pedro Alves
2017-01-17 17:13 ` Luis Machado [this message]
2017-01-31 14:39 ` Jerome Guitton
2017-01-31 15:20 ` Pedro Alves
2017-02-08 18:05 ` Jerome Guitton
2017-07-24 21:17 ` Simon Marchi
2017-07-24 21:48 ` [PATCH] define_command: Don't convert command name to lower case Simon Marchi
2017-07-24 21:54 ` Simon Marchi
2017-08-28 21:20 ` Simon Marchi
2017-07-26 12:42 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3637d6-0571-b7fc-c9ba-d3b635f07435@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox