From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33156 invoked by alias); 17 Jan 2017 17:13:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33142 invoked by uid 89); 17 Jan 2017 17:13:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1308, H*i:sk:95bcfea, H*MI:sk:95bcfea, H*f:sk:95bcfea X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jan 2017 17:13:56 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cTXKT-0005Vx-33 from Luis_Gustavo@mentor.com ; Tue, 17 Jan 2017 09:13:53 -0800 Received: from [172.30.8.199] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 17 Jan 2017 09:13:49 -0800 Reply-To: Luis Machado Subject: Re: [RFA] candidates for ambiguous command in upper case References: <1484058324-5368-1-git-send-email-guitton@adacore.com> <20170110150731.GH9518@E107787-LIN> <20170110151944.GD27546@adacore.com> <2c7e674b-e827-f433-cbaf-a3d1a20cba80@redhat.com> <20170111172550.GL9518@E107787-LIN> <20170112101854.GL27546@adacore.com> <85ecb095-a990-6f15-4fe9-5addffb3a5d0@redhat.com> <20170116163210.GG27546@adacore.com> <6872438c-e93a-77e8-79a3-c8e1f05aa283@codesourcery.com> <95bcfead-6b1a-305c-5064-0ffe961ca5f0@redhat.com> To: Pedro Alves , Jerome Guitton CC: Yao Qi , Simon Marchi , From: Luis Machado Message-ID: Date: Tue, 17 Jan 2017 17:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <95bcfead-6b1a-305c-5064-0ffe961ca5f0@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00332.txt.bz2 On 01/17/2017 11:04 AM, Pedro Alves wrote: > On 01/17/2017 04:51 PM, Luis Machado wrote: >> On 01/17/2017 10:34 AM, Pedro Alves wrote: >>> On 01/17/2017 04:29 PM, Luis Machado wrote: >>>> >>>> I don't see a problem with #1 as long as we keep it consistent >>>> throughout from now on. >>> >>> Can you expand on exactly what you mean by the "as long" part? > >> Meaning that, if we go with #1, we should make sure we are not doing >> case-insensitive comparisons in gdb unless it is clearly stated we >> should do it (like handling of Windows paths i suppose). > > Would you say that we should stop completing "handle sig" to "handle SIG"? > "handle" doesn't accept lowercase signal names, but it could be > argued that the completer is helping the user here. > That sounds like a one-off case where it is useful. > Grepping for strncasecmp doesn't find all that many hits, and several > are in symbol lookup or path handling stuff where they're probably rightly > used. > I'll go through the code to see if there are any other occurrences. > The ones in tracepoint.c do look like of the inconsistent-user-interface sort. > I had never realized we accept $REG etc. in tracepoint actions. > Neither did i. This one looks like it could be dropped.