Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove Java support
Date: Thu, 06 Oct 2016 13:32:00 -0000	[thread overview]
Message-ID: <ecdc55c1-cbb0-f884-b958-576358020729@redhat.com> (raw)
In-Reply-To: <1475679082-29898-1-git-send-email-tom@tromey.com>

I asked a bit internally at RH, and seems like nobody will
miss this, other than for nostalgic reasons.

On 10/05/2016 03:51 PM, Tom Tromey wrote:
> This patch removes the Java support from gdb.  gcj has not seen much
> development or use for years now, and was recently removed from GCC.
> This patch changes gdb to follow; in the unlikely event that there are
> still users using gcj, they can continue to use an older gdb to debug.
> Or, they can debug in C++ mode.
> 
> If this goes in, I intend to also close all the open java bugs as
> "wontfix".

Fine with me.

Do you also plan on removing the java demangling support from libiberty?

> diff --git a/gdb/testsuite/gdb.base/setshow.exp b/gdb/testsuite/gdb.base/setshow.exp
> index 2a86cdd..22d5161 100644
> --- a/gdb/testsuite/gdb.base/setshow.exp
> +++ b/gdb/testsuite/gdb.base/setshow.exp
> @@ -211,10 +211,6 @@ gdb_test "show history size" "The size of the command history is 100..*" "show h
>  gdb_test "set language asm" ".*" "set language asm" 
>  #test show language asm
>  gdb_test "show language" "The current source language is \"asm\"..*" "show language (asm)" 
> -#test set language java, with a trailing space
> -gdb_test_no_output "set language java " "set language java"
> -#test show language java
> -gdb_test "show language" "The current source language is \"java\"..*" "show language (java)" 
>  #test completion for set language.

This was a regression test for

commit bda180e01110741f20d30b95c3ae0d93e957de8a
Author:     Tom Tromey <tromey@redhat.com>

    gdb
        * language.c (set_language_command): Strip whitespace.
        (set_type_command): Likewise.
        (set_range_command): Likewise.
    gdb/testsuite
        * gdb.base/setshow.exp: Add tests for changes to set language, set
        check range, and set check type.

Seems like we should keep it, but use some other language?

Otherwise all looked good to me.

Thanks,
Pedro Alves


  parent reply	other threads:[~2016-10-06 13:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 14:52 Tom Tromey
2016-10-05 16:04 ` Eli Zaretskii
2016-10-06 13:32 ` Pedro Alves [this message]
2016-10-06 15:34   ` Tom Tromey
2016-10-06 16:14     ` Pedro Alves
2016-10-06 16:19       ` Tom Tromey
2016-10-06 16:40     ` Tom Tromey
2016-10-06 16:45       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecdc55c1-cbb0-f884-b958-576358020729@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox