From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31323 invoked by alias); 6 Oct 2016 13:32:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31303 invoked by uid 89); 6 Oct 2016 13:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1899 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 13:32:10 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DBCFB6199F; Thu, 6 Oct 2016 13:32:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u96DW7h3026478; Thu, 6 Oct 2016 09:32:08 -0400 Subject: Re: [RFA] Remove Java support To: Tom Tromey , gdb-patches@sourceware.org References: <1475679082-29898-1-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 06 Oct 2016 13:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475679082-29898-1-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00118.txt.bz2 I asked a bit internally at RH, and seems like nobody will miss this, other than for nostalgic reasons. On 10/05/2016 03:51 PM, Tom Tromey wrote: > This patch removes the Java support from gdb. gcj has not seen much > development or use for years now, and was recently removed from GCC. > This patch changes gdb to follow; in the unlikely event that there are > still users using gcj, they can continue to use an older gdb to debug. > Or, they can debug in C++ mode. > > If this goes in, I intend to also close all the open java bugs as > "wontfix". Fine with me. Do you also plan on removing the java demangling support from libiberty? > diff --git a/gdb/testsuite/gdb.base/setshow.exp b/gdb/testsuite/gdb.base/setshow.exp > index 2a86cdd..22d5161 100644 > --- a/gdb/testsuite/gdb.base/setshow.exp > +++ b/gdb/testsuite/gdb.base/setshow.exp > @@ -211,10 +211,6 @@ gdb_test "show history size" "The size of the command history is 100..*" "show h > gdb_test "set language asm" ".*" "set language asm" > #test show language asm > gdb_test "show language" "The current source language is \"asm\"..*" "show language (asm)" > -#test set language java, with a trailing space > -gdb_test_no_output "set language java " "set language java" > -#test show language java > -gdb_test "show language" "The current source language is \"java\"..*" "show language (java)" > #test completion for set language. This was a regression test for commit bda180e01110741f20d30b95c3ae0d93e957de8a Author: Tom Tromey gdb * language.c (set_language_command): Strip whitespace. (set_type_command): Likewise. (set_range_command): Likewise. gdb/testsuite * gdb.base/setshow.exp: Add tests for changes to set language, set check range, and set check type. Seems like we should keep it, but use some other language? Otherwise all looked good to me. Thanks, Pedro Alves