From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <pedro@palves.net>,
Luis Machado <luis.machado@linaro.org>,
gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: remove TYPE_INSTANCE_FLAGS
Date: Wed, 16 Sep 2020 16:44:23 -0400 [thread overview]
Message-ID: <eb7441e8-5109-c474-d2f2-08c08d49da3c@simark.ca> (raw)
In-Reply-To: <a2958bb8-b424-7d00-9238-d07381edaf07@palves.net>
On 2020-09-16 7:01 a.m., Pedro Alves wrote:
> On 9/16/20 3:50 AM, Simon Marchi wrote:
>> On 2020-09-15 5:28 p.m., Luis Machado wrote:
>>> I think you missed adjusting the stale references in gdb/gdb-gdb.py.in.
>>
>> I wasn't sure what you meant, but I suppose it is:
>>
>> 115 fields.append("instance_flags = %s"
>> 116 % TypeFlagsPrinter(self.val['instance_flags']))
>>
>> ? Indeed, instance_flags there should be changed to m_instance_flags.
>
> My fault then, sorry about that.
>
>> Does the
>> patch below look good?
>
> Looks fine to me.
>
> Thanks for fixing it.
Thanks, I pushed it.
Simon
next prev parent reply other threads:[~2020-09-16 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 21:31 [pushed v2 0/4] Rewrite enum_flags, add unit tests, fix problems Pedro Alves
2020-09-14 21:31 ` [pushed v2 1/4] Use type_instance_flags more throughout Pedro Alves
2020-09-15 2:28 ` [pushed] gdb: remove TYPE_INSTANCE_FLAGS Simon Marchi
2020-09-15 21:28 ` Luis Machado
2020-09-16 2:50 ` Simon Marchi
2020-09-16 11:01 ` Pedro Alves
2020-09-16 20:44 ` Simon Marchi [this message]
2020-09-14 21:31 ` [pushed v2 2/4] Rename address_space_int_to_name/address_space_name_to_int Pedro Alves
2020-09-14 21:31 ` [pushed v2 3/4] Rewrite valid-expr.h's internals in terms of the detection idiom (C++17/N4502) Pedro Alves
2020-09-17 10:57 ` Vaseeharan Vinayagamoorthy
2020-09-17 11:41 ` Luis Machado
2020-09-17 16:10 ` Vaseeharan Vinayagamoorthy
2020-09-17 16:23 ` Luis Machado
2020-09-14 21:31 ` [pushed v2 4/4] Rewrite enum_flags, add unit tests, fix problems Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb7441e8-5109-c474-d2f2-08c08d49da3c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox